From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c
Date: Thu, 11 Apr 2019 03:14:04 +0300 [thread overview]
Message-ID: <B9529F91-2A89-4E8C-85D0-50480292B49D@tarantool.org> (raw)
In-Reply-To: <61b31e4086c3914a3b76683e531e1309a70cd291.1554830037.git.imeevma@gmail.com>
> On 9 Apr 2019, at 20:17, imeevma@tarantool.org wrote:
>
> These functions unused and should be removed.
Nit: are unused.
> Needed for #4074
Why it is ’needed for’? This removal seems to be quite optional.
Patch is OK as obvious.
prev parent reply other threads:[~2019-04-11 0:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 17:17 [tarantool-patches] [PATCH v1 0/3] sql: remove unused code from SQL imeevma
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 1/3] sql: remove legacy.c imeevma
2019-04-10 7:26 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:02 ` n.pettik
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 2/3] sql: remove unused macros in SQL imeevma
2019-04-10 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:08 ` n.pettik
2019-04-11 16:56 ` Imeev Mergen
2019-04-12 13:08 ` Mergen Imeev
2019-04-22 15:39 ` n.pettik
2019-04-23 8:59 ` Kirill Yukhin
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 3/3] sql: remove unused functions from main.c imeevma
2019-04-10 7:31 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:24 ` n.pettik
2019-04-11 6:36 ` Konstantin Osipov
2019-04-11 0:14 ` n.pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9529F91-2A89-4E8C-85D0-50480292B49D@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox