[tarantool-patches] Re: [PATCH v4 6/8] sql: refactor AST trigger object name

["n.pettik" <korablev@tarantool.org>]

> -void sql_trigger_finish(Parse *, TriggerStep *, Token *);
> +void
> +sql_trigger_finish(struct Parse *parse, struct TriggerStep *step_list,
> +                  struct Token *token);
> 
>> You don’t need to declare all variables beforehand: its obsolete style
>> used in SQLite.
> It is important here, as there is goto clause before first usage. 
> This variable should be initialized with NULL. 

I mean not all of these variables are initialised. For example, you can move

/* Name of trigger. */
char *trigger_name;

closer to its usage. Surely, it is not vital, but anyway.