From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v2] sql: prohibit type_def keywords in the VALUES statement
Date: Tue, 29 Jan 2019 15:31:56 +0300 [thread overview]
Message-ID: <AE8DB4D0-99D0-423A-BDCE-BED27192229D@tarantool.org> (raw)
In-Reply-To: <20190129105518.22723-1-szudin@tarantool.org>
> The parser didn't distinguish the type definition keywords from values.
Why did you change your commit message? It was good except for
that it was not formatted. Lets return it back, format (align text border
to 72 chars) and then patch will be entirely OK.
> Closes #3888
> ---
> Branch: https://github.com/tarantool/tarantool/tree/sz/gh-3888-values-blob-assert
> Issue: https://github.com/tarantool/tarantool/issues/3888
> —
Don’t put this delimiter again (next time), it should appear only once.
next prev parent reply other threads:[~2019-01-29 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 10:55 [tarantool-patches] " Stanislav Zudin
2019-01-29 12:31 ` n.pettik [this message]
2019-01-29 13:12 ` [tarantool-patches] " Stanislav Zudin
2019-01-30 7:51 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE8DB4D0-99D0-423A-BDCE-BED27192229D@tarantool.org \
--to=korablev@tarantool.org \
--cc=szudin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2] sql: prohibit type_def keywords in the VALUES statement' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox