From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 3/3] sql: too many autogenerated ids leads to SEGFAULT
Date: Mon, 19 Nov 2018 20:27:42 +0300 [thread overview]
Message-ID: <ADF4F323-ADF3-47A7-BF0B-08FC61898113@tarantool.org> (raw)
In-Reply-To: <6128bdce00cc4c6d47c122897c195e30e0416613.1542635129.git.v.shpilevoy@tarantool.org>
> This probleam appeared because region was cleaned twice: once in
Typo: problem
> sqlite3VdbeHalt() and once in sqlite3VdbeDelete() which was
> executed during sqlite3_finalize(). Autogenerated ids that were
> saved there, were fetched after sqlite3VdbeHalt() and before
> sqlite3_finalize(). In this patch region cleaning in
> sqlite3VdbeHalt() were removed.
Typo: was (or better - has been removed).
Again, IMHO I would rephrase commit subject:
sql: remove region_truncate() from sqlite3VdbeHalt()
And explain in commit message why it was removed.
Patch itself is OK.
next prev parent reply other threads:[~2018-11-19 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 13:47 [tarantool-patches] [PATCH 0/3] A set of small SQL fixes Vladislav Shpilevoy
2018-11-19 13:47 ` [tarantool-patches] [PATCH 1/3] sql: EXPLAIN through net.box leads to SEGFAULT Vladislav Shpilevoy
2018-11-19 17:27 ` [tarantool-patches] " n.pettik
2018-11-22 18:08 ` Imeev Mergen
2018-11-22 18:31 ` Vladislav Shpilevoy
2018-11-22 20:55 ` [tarantool-patches] Re[2]: " Мерген Имеев
2018-11-23 6:04 ` [tarantool-patches] Re: Re[2]: " Kirill Yukhin
2018-11-28 12:36 ` [tarantool-patches] " n.pettik
2018-11-29 14:58 ` Konstantin Osipov
2018-11-19 13:47 ` [tarantool-patches] [PATCH 2/3] sql: SELECT from system spaces returns unpacked msgpack Vladislav Shpilevoy
2018-11-19 17:27 ` [tarantool-patches] " n.pettik
2018-11-22 18:09 ` Imeev Mergen
2018-11-27 8:51 ` n.pettik
2018-11-19 13:47 ` [tarantool-patches] [PATCH 3/3] sql: too many autogenerated ids leads to SEGFAULT Vladislav Shpilevoy
2018-11-19 17:27 ` n.pettik [this message]
2018-11-22 18:09 ` [tarantool-patches] " Imeev Mergen
2018-11-27 8:50 ` n.pettik
2018-11-27 10:09 ` [tarantool-patches] Re: [PATCH 0/3] A set of small SQL fixes Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ADF4F323-ADF3-47A7-BF0B-08FC61898113@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 3/3] sql: too many autogenerated ids leads to SEGFAULT' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox