From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v2 7/8] sql: get rid of FuncDef function hash Date: Tue, 20 Aug 2019 19:06:03 +0300 [thread overview] Message-ID: <ACC61156-B7C0-4DB0-B950-36AA429DD5D0@tarantool.org> (raw) In-Reply-To: <00293576-fea9-151f-11cf-85afe76b065e@tarantool.org> >>> + /** A call method for a function. */ >> >> Add explanation why we don’t use basic (i.e. call >> method of base class) “call” method. Furthermore, >> built-ins are called bypassing func_access_check() >> function. This should be either documented or fixed. > /** > * A VDBE-memory-compatible call method for a function. > * SQL Builting functions doesn't use base class call Builting -> built-in; doesn’t -> don't > * method to gain the best possible performance for SQL > * requests. Can’t parse this sentence at all. > As builtin functions are predefined and > * non of them modifie schema, access checks are God please, use spell checker. > * redundant, functions have the same execution > * privileges as SQL. > */ > void (*call)(sql_context *ctx, int argc, sql_value **argv); > >>> +/** >>> + * Memory cell pMem contains the context of an aggregate function. >> >> Nit: pMem -> mem. > Fixed. It’s not. >>> assert(func != NULL); >> >> Instead of asserting func existence let’s raise an error: now >> user can remove built-in function from hash - there’s no >> protection to avoid such cases. Note that such opportunity >> (removing built-ins from cache) has been introduced by moving >> built-ins to the global func cache. In this case, assertion will fail >> in debug mode and lead to unpredictable consequences in >> release mode. Another option is to introduce mentioned protection, >> i.e. disallow user to delete functions which are declared with >> FUNC_LANGUAGE_SQL_BUILTIN flag. > I've introduce remove protection in alter.cc Well, now we have another problem: user can create built-in function, but can’t drop it: tarantool> box.schema.func.create('WAITFOR', {language = 'SQL_BUILTIN', param_list = {'integer'}, returns = 'integer',exports = {'SQL'}}) --- … tarantool> box.schema.func.drop('WAITFOR') --- - error: 'Can''t drop function 1: function is SQL builtin' ... >> Can aggregate function be non-builtin? > Not for now, but I don't like to rely on it so I make all > corresponding checks. Please, don’t cut the context related to comment. Add assertion than, instead of absolutely redundant if-check. If someday ability of declaring non-builtins as aggregates would be introduced, one can easily find and fix this place. >> user_data is used only for min/max functions. Let’s consider removing it. > Removed user_data at all. I’d better move it in a separate commit.
next prev parent reply other threads:[~2019-08-20 16:06 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-08 14:50 [tarantool-patches] [PATCH v2 0/8] sql: uniform SQL and Lua functions subsystem Kirill Shcherbatov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 1/8] sql: remove SQL_PreferBuiltin flag Kirill Shcherbatov 2019-08-09 16:07 ` [tarantool-patches] " n.pettik 2019-08-12 21:58 ` Konstantin Osipov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 2/8] sql: GREATEST, LEAST instead of MIN/MAX overload Kirill Shcherbatov 2019-08-09 17:37 ` [tarantool-patches] " n.pettik 2019-08-13 8:26 ` Kirill Shcherbatov 2019-08-12 21:59 ` Konstantin Osipov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 3/8] sql: wrap all trim functions in dispatcher Kirill Shcherbatov 2019-08-09 18:05 ` [tarantool-patches] " n.pettik 2019-08-13 8:28 ` Kirill Shcherbatov 2019-08-13 22:19 ` n.pettik 2019-08-12 22:00 ` Konstantin Osipov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 4/8] sql: get rid of SQL_FUNC_COUNT flag Kirill Shcherbatov 2019-08-12 22:01 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 20:35 ` n.pettik 2019-08-14 7:25 ` Kirill Shcherbatov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 5/8] sql: introduce a signature_mask for functions Kirill Shcherbatov 2019-08-12 22:04 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 8:32 ` Kirill Shcherbatov 2019-08-13 8:44 ` Konstantin Osipov 2019-08-13 20:38 ` n.pettik 2019-08-14 7:21 ` Kirill Shcherbatov 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 6/8] sql: rename OP_Function to OP_BuiltinFunction Kirill Shcherbatov 2019-08-12 22:04 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 20:36 ` n.pettik 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 7/8] sql: get rid of FuncDef function hash Kirill Shcherbatov 2019-08-12 22:11 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 7:29 ` Kirill Shcherbatov 2019-08-13 8:42 ` Konstantin Osipov 2019-08-13 9:45 ` Kirill Shcherbatov 2019-08-13 20:40 ` n.pettik 2019-08-16 12:57 ` Kirill Shcherbatov 2019-08-20 16:06 ` n.pettik [this message] 2019-08-08 14:50 ` [tarantool-patches] [PATCH v2 8/8] box: get rid of box.internal.sql_function_create Kirill Shcherbatov 2019-08-13 20:43 ` [tarantool-patches] " n.pettik 2019-08-16 12:57 ` Kirill Shcherbatov 2019-08-20 19:36 ` n.pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ACC61156-B7C0-4DB0-B950-36AA429DD5D0@tarantool.org \ --to=korablev@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 7/8] sql: get rid of FuncDef function hash' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox