From: "i.koptelov" <ivan.koptelov@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\0'
Date: Mon, 4 Mar 2019 14:59:33 +0300 [thread overview]
Message-ID: <AC2B2A28-05CE-47F7-83FC-05FE541CF593@tarantool.org> (raw)
In-Reply-To: <bb9e1bab-69a7-6c12-569c-bcd99fa99204@tarantool.org>
> On 26 Feb 2019, at 23:16, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
>
>
>
> On 26/02/2019 21:44, i.koptelov wrote:
>>> On 26 Feb 2019, at 20:50, n.pettik <korablev@tarantool.org> wrote:
>>>
>>> Won’t bother you with portion of minor comments.
>>> I’ve pushed them, take a look. If they are OK, just
>>> squash (but don’t squash last commit) them and
>>> patch will be OK as well.
>>>
>>> Also, I’ve fixed a bit commit message. Add please
>>> doc request which includes user-visible changes.
>> Thank you for the fixes! They are OK for me.
>> Squashed them. Added doc request into the
>> commit message.
>
> If under a doc request you mean that: https://github.com/tarantool/tarantool/commit/4704f531fc4af0e074410c552a4f3a9d9848c949 then it is incorrect. Please, look at
> tarantool/docbot for the proper syntax, and check your requests in the online
> table: https://tarantool-docbot.herokuapp.com
>
> If you do not see your request here, then it is incorrect.
>
Thank you, I’ve changed the commit message. Now I can see my
doc request in the online table.
next prev parent reply other threads:[~2019-03-04 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 9:56 [tarantool-patches] " Ivan Koptelov
2019-01-29 16:35 ` [tarantool-patches] " n.pettik
2019-02-04 12:34 ` Ivan Koptelov
2019-02-05 13:50 ` n.pettik
2019-02-07 15:14 ` i.koptelov
2019-02-11 13:15 ` n.pettik
2019-02-13 15:46 ` i.koptelov
2019-02-14 12:57 ` n.pettik
2019-02-20 13:54 ` i.koptelov
2019-02-20 15:47 ` i.koptelov
2019-02-20 16:04 ` n.pettik
2019-02-20 18:08 ` Vladislav Shpilevoy
2019-02-20 19:24 ` i.koptelov
2019-02-22 12:59 ` n.pettik
2019-02-25 11:09 ` i.koptelov
2019-02-25 15:10 ` n.pettik
2019-02-26 13:33 ` i.koptelov
2019-02-26 17:50 ` n.pettik
2019-02-26 18:44 ` i.koptelov
2019-02-26 20:16 ` Vladislav Shpilevoy
2019-03-04 11:59 ` i.koptelov [this message]
2019-03-04 15:30 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC2B2A28-05CE-47F7-83FC-05FE541CF593@tarantool.org \
--to=ivan.koptelov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: LIKE/LENGTH process '\''\0'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox