From: Chris Sosnin <k.sosnin@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: fix assertion fail when selecting from _vfunc
Date: Thu, 16 Jan 2020 11:10:32 +0300 [thread overview]
Message-ID: <AB55A62C-AA31-4EFF-B572-E813077B733A@tarantool.org> (raw)
In-Reply-To: <20200115172944.GC82780@tarantool.org>
Hi! Thank you for the review!
> LGTM as well. Don't you forget edit snapshot in binary mode (asking
> just in case)?
I have done it using vim -b.
next prev parent reply other threads:[~2020-01-16 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 7:40 Chris Sosnin
2020-01-15 17:29 ` Nikita Pettik
2020-01-16 8:10 ` Chris Sosnin [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-17 10:26 Chris Sosnin
2019-12-20 21:10 ` Vladislav Shpilevoy
2019-12-21 18:57 ` Chris Sosnin
2019-12-22 15:00 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AB55A62C-AA31-4EFF-B572-E813077B733A@tarantool.org \
--to=k.sosnin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sql: fix assertion fail when selecting from _vfunc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox