Re: [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int

[Chris Sosnin <k.sosnin@tarantool.org>]

Thank you for your answers, this will be helpful.

> On 28 Jun 2020, at 19:53, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
> 
> On 26/06/2020 13:58, Chris Sosnin wrote:
>> Thank you for the review!
>> For some reason I thought we don't need a wrapper for a function
>> that doesn't require context and the status check.
> 
> You need. Because decNumber code style is too different, even in
> declarations. Also we use decimal_t type, not decNumber. Even though
> they are the same for now. But this may change.
> 
>> So does it mean
>> I should also wrap isZero and similar calls in my SQL patchset?
> 
> Yes. All decimal functions should be decimal_*(). Not decNumber*(). At
> least this is how I understand it. Sergey may have different thoughts.
> 
> The patchset LGTM.

decNumber patchset has 2 LGTMs, and wrappers for the core have one, can we push it?
I could rebase on it and continue finalizing decimals.