Re: [Tarantool-patches] [PATCH v2 1/4] refactoring: extract mpstream into a separate library

[Serge Petrenko <sergepetrenko@tarantool.org>]

> 10 апр. 2020 г., в 19:56, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
> 
> Thanks for the patch!

Thanks for the review!

> 
>> diff --git a/src/lib/core/mpstream.c b/src/lib/mpstream/mpstream.c
>> similarity index 99%
>> rename from src/lib/core/mpstream.c
>> rename to src/lib/mpstream/mpstream.c
>> index 2be1797d0..a737212c1 100644
>> --- a/src/lib/core/mpstream.c
>> +++ b/src/lib/mpstream/mpstream.c
>> @@ -33,7 +33,7 @@
>> #include <assert.h>
>> #include <stdint.h>
>> #include "msgpuck.h"
>> -#include "mp_decimal.h"
>> +#include "core/mp_decimal.h"
> 
> You can keep it as is, anyway core/ is added to -I, so
> all files there are visible without core/ prefix. In all
> next patches too.

Indeed, thanks!

diff --git a/src/lib/mpstream/mpstream.c b/src/lib/mpstream/mpstream.c
index a737212c1..2be1797d0 100644
--- a/src/lib/mpstream/mpstream.c
+++ b/src/lib/mpstream/mpstream.c
@@ -33,7 +33,7 @@
 #include <assert.h>
 #include <stdint.h>
 #include "msgpuck.h"
-#include "core/mp_decimal.h"
+#include "mp_decimal.h"
 
 void
 mpstream_reserve_slow(struct mpstream *stream, size_t size)

--
Serge Petrenko
sergepetrenko@tarantool.org