From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int
Date: Sun, 28 Jun 2020 18:53:37 +0200 [thread overview]
Message-ID: <9f523f8f-cb74-bb61-e044-b8d82692d28a@tarantool.org> (raw)
In-Reply-To: <20200626115843.68530-1-k.sosnin@tarantool.org>
On 26/06/2020 13:58, Chris Sosnin wrote:
> Thank you for the review!
> For some reason I thought we don't need a wrapper for a function
> that doesn't require context and the status check.
You need. Because decNumber code style is too different, even in
declarations. Also we use decimal_t type, not decNumber. Even though
they are the same for now. But this may change.
> So does it mean
> I should also wrap isZero and similar calls in my SQL patchset?
Yes. All decimal functions should be decimal_*(). Not decNumber*(). At
least this is how I understand it. Sergey may have different thoughts.
The patchset LGTM.
next prev parent reply other threads:[~2020-06-28 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 14:23 [Tarantool-patches] [PATCH 0/2] decimal: intrdoduce strtodec and IsInt Chris Sosnin
2020-06-25 14:23 ` [Tarantool-patches] [PATCH 1/2] decNumber: bump new version Chris Sosnin
2020-06-25 14:23 ` [Tarantool-patches] [PATCH 2/2] decimal: introduce strtodec function Chris Sosnin
2020-06-25 21:03 ` [Tarantool-patches] [PATCH 0/2] decimal: intrdoduce strtodec and IsInt Vladislav Shpilevoy
2020-06-26 11:58 ` [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int Chris Sosnin
2020-06-28 16:53 ` Vladislav Shpilevoy [this message]
2020-07-02 10:25 ` Chris Sosnin
2020-07-02 20:11 ` [Tarantool-patches] [PATCH 0/2] decimal: intrdoduce strtodec and IsInt Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f523f8f-cb74-bb61-e044-b8d82692d28a@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox