Re: [Tarantool-patches] [PATCH V6 00/10] Extending error functionality

[lvasiliev <lvasiliev@tarantool.org>]

On 21.04.2020 22:03, Konstantin Osipov wrote:
> * Kirill Yukhin <kyukhin@tarantool.org> [20/04/20 11:08]:
>>> It is still unfinished because of underdesigned traceback
>>> feature, because of payload absence. IMO, MP_EXT is also an
>>> overkill. Tuples live fine as MP_ARRAY, and they are the most
>>> used type. We should have gone for simple MP_MAP, without
>>> MP_EXT. Just a map.
>>
>> We already broken connectors by introducing UUID (w/ MP_EXT).

I’ll add for clarity: "MP_ERROR doesn't break connectors because
IPROTO_ERROR doesn't use MP_EXT, MP_ERROR used at IPROTO_BODY after
client do session_settings update."
> 
> UUID change was planned. This was not. UUID is a fundamental data
> type. struct error is just an object.
> 
> This was a rushed up decision. Better revert it and go back to
> MP_MAP.
>>> It is worth mentioning separately, how hard it is to use the
>>> error marshaling now, because of this session setting. And
>>> there still is no way to enable the feature without touching
>>> the session, even if all my connectors support it. As I
>>> mentioned, enabling it for every session manually is a
>>> non-trivial task for a user.
>>
>> I guess we can switch it on by default in future releases.
>>
>>> But we have releases coming, so lets push all in whatever
>>> state it is, of course.
>>
>> --
>> Regards, Kirill Yukhin
>