From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Igor Munkin <imun@tarantool.org>,
Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over
Date: Wed, 30 Sep 2020 00:41:43 +0200 [thread overview]
Message-ID: <9f25b850-0c4e-f3c4-7762-22065ebfbc48@tarantool.org> (raw)
In-Reply-To: <12d3cc3577e45946a82c8d23b69508a4c5653346.1600862684.git.imun@tarantool.org>
Hi! Thanks for the patch!
> diff --git a/test/unit/CMakeLists.txt b/test/unit/CMakeLists.txt
> index 419477748..aace8cf50 100644
> --- a/test/unit/CMakeLists.txt
> +++ b/test/unit/CMakeLists.txt
> @@ -50,7 +50,7 @@ add_executable(bitset_index.test bitset_index.c)
> target_link_libraries(bitset_index.test bitset)
> add_executable(base64.test base64.c)
> target_link_libraries(base64.test misc unit)
> -add_executable(uuid.test uuid.c)
> +add_executable(uuid.test uuid.c core_test_utils.c)
To make lib/core more self-sufficient we could make cord_on_yield
inlined in fiber.h under a macros like LIBCORE_USE_DEFAULT_ON_YIELD.
Which would be set by default to 1, but to 0 in the executable file.
Could help not to change the test binaries, and whatever else depends
on lib/core, but does not care about Lua.
I do not insist, but I will do that myself if someday I will need to
write a new unit test (raft, for example).
next prev parent reply other threads:[~2020-09-29 22:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 19:06 [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on " Igor Munkin
2020-09-23 19:06 ` [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for " Igor Munkin
2020-09-24 12:54 ` sergos
2020-09-28 13:06 ` Igor Munkin
2020-09-29 9:15 ` Sergey Ostanevich
2020-09-29 10:05 ` Igor Munkin
2020-09-29 22:41 ` Vladislav Shpilevoy [this message]
2020-09-30 9:30 ` Igor Munkin
2020-09-30 22:00 ` Vladislav Shpilevoy
2020-09-23 19:06 ` [Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield Igor Munkin
2020-09-24 13:00 ` sergos
2020-09-28 13:07 ` Igor Munkin
2020-09-28 15:36 ` Igor Munkin
2020-09-28 16:37 ` Igor Munkin
2020-09-28 17:45 ` Igor Munkin
2020-09-29 9:24 ` Sergey Ostanevich
2020-09-29 10:06 ` Igor Munkin
2020-09-29 22:41 ` Vladislav Shpilevoy
2020-09-30 6:27 ` Igor Munkin
2020-09-30 21:59 ` Vladislav Shpilevoy
2020-10-01 6:14 ` Igor Munkin
2020-09-24 13:15 ` [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on fibers switch-over sergos
2020-09-28 13:06 ` Igor Munkin
2020-09-29 9:14 ` Sergey Ostanevich
2020-10-01 21:25 ` Vladislav Shpilevoy
2020-10-01 21:29 ` Igor Munkin
2020-10-01 22:17 ` Igor Munkin
2020-10-02 12:43 ` Kirill Yukhin
2020-10-02 12:44 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f25b850-0c4e-f3c4-7762-22065ebfbc48@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imun@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for fibers switch-over' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox