From: Ilya Kosarev <i.kosarev@tarantool.org> To: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v5 8/8] refactoring: remove try..catch wrapper around trigger->run Date: Fri, 22 Nov 2019 05:46:56 +0300 [thread overview] Message-ID: <9e4dba1fbf7d9c3809666da1770f2b4699255da1.1574390065.git.i.kosarev@tarantool.org> (raw) In-Reply-To: <cover.1574390065.git.i.kosarev@tarantool.org> In-Reply-To: <cover.1574390065.git.i.kosarev@tarantool.org> Triggers don't throw exceptions any more. Now they have return codes to report errors. Closes #4247 --- src/lib/core/trigger.cc | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/lib/core/trigger.cc b/src/lib/core/trigger.cc index 8f6a83fb5..7fe112f8b 100644 --- a/src/lib/core/trigger.cc +++ b/src/lib/core/trigger.cc @@ -30,32 +30,23 @@ */ #include "trigger.h" -#include "exception.h" int trigger_run(struct rlist *list, void *event) { - try { - struct trigger *trigger, *tmp; - rlist_foreach_entry_safe(trigger, list, link, tmp) - if (trigger->run(trigger, event) != 0) - return -1; - } catch (Exception *e) { - return -1; - } + struct trigger *trigger, *tmp; + rlist_foreach_entry_safe(trigger, list, link, tmp) + if (trigger->run(trigger, event) != 0) + return -1; return 0; } int trigger_run_reverse(struct rlist *list, void *event) { - try { - struct trigger *trigger, *tmp; - rlist_foreach_entry_safe_reverse(trigger, list, link, tmp) - if (trigger->run(trigger, event) != 0) - return -1; - } catch (Exception *e) { - return -1; - } + struct trigger *trigger, *tmp; + rlist_foreach_entry_safe_reverse(trigger, list, link, tmp) + if (trigger->run(trigger, event) != 0) + return -1; return 0; } -- 2.17.1
next prev parent reply other threads:[~2019-11-22 2:47 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-22 2:46 [Tarantool-patches] [PATCH v5 0/8] refactoring: remove exceptions from triggers follow-ups Ilya Kosarev 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 1/8] refactoring: wrap new operator calls in triggers Ilya Kosarev 2019-11-26 15:07 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 2/8] refactoring: specify struct name in allocation diagnostics Ilya Kosarev 2019-11-27 13:25 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 3/8] refactoring: recombine error conditions in triggers Ilya Kosarev 2019-11-27 13:28 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 4/8] refactoring: set diagnostics if sequence_by_id fails Ilya Kosarev 2019-11-27 13:40 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 5/8] refactoring: clear triggers from fresh exceptions Ilya Kosarev 2019-11-27 14:59 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 6/8] refactoring: update comment for index_def_check_tuple Ilya Kosarev 2019-11-27 14:59 ` Sergey Ostanevich 2019-11-22 2:46 ` [Tarantool-patches] [PATCH v5 7/8] refactoring: remove redundant line in txn_alter_trigger_new Ilya Kosarev 2019-11-27 15:00 ` Sergey Ostanevich 2019-11-22 2:46 ` Ilya Kosarev [this message] 2019-11-27 15:01 ` [Tarantool-patches] [PATCH v5 8/8] refactoring: remove try..catch wrapper around trigger->run Sergey Ostanevich 2019-12-02 7:41 ` [Tarantool-patches] [PATCH v5 0/8] refactoring: remove exceptions from triggers follow-ups Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9e4dba1fbf7d9c3809666da1770f2b4699255da1.1574390065.git.i.kosarev@tarantool.org \ --to=i.kosarev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v5 8/8] refactoring: remove try..catch wrapper around trigger->run' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox