[tarantool-patches] Re: [PATCH v2 1/1] sql: parameter binding for box.execute()

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

LGTM.

On 01/04/2019 23:02, Vladislav Shpilevoy wrote:
> From: Mergen Imeev <imeevma@gmail.com>
> 
> This patch defines parameters binding for SQL statements executed
> through box.execute().
> 
> Closes #3401
> ---
> 
> Changes in v2:
> - All the code is moved to box/lua/execute.h
> 
> V1: https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-parameter-binding-for-boxexecute
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3401-add-binding-to-box_execute
> Issue: https://github.com/tarantool/tarantool/issues/3401
> 
>  src/box/lua/execute.c    | 179 ++++++++++++++++++++++-
>  test/sql/bind.result     | 296 +++++++++++++++++++++++++++++++++++++++
>  test/sql/bind.test.lua   | 100 +++++++++++++
>  test/sql/engine.cfg      |   4 +
>  test/sql/iproto.result   | 225 -----------------------------
>  test/sql/iproto.test.lua |  69 ---------
>  6 files changed, 577 insertions(+), 296 deletions(-)
>  create mode 100644 test/sql/bind.result
>  create mode 100644 test/sql/bind.test.lua
>