From: Artem Starshov <artemreyt@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 2/3] github-ci: add init option for containers
Date: Tue, 29 Dec 2020 19:25:34 +0300 [thread overview]
Message-ID: <9dab8309753f75099b4f4fdf7e8e86e66051f342.1609259010.git.artemreyt@tarantool.org> (raw)
In-Reply-To: <cover.1609259010.git.artemreyt@tarantool.org>
From: Alexander Turenko <alexander.turenko@tarantool.org>
Now we have a PID 1 zombie reaping problem, when zombie
processes launched in Docker aren't collected by init,
how it would be done if we launch it on Unix.
It is fixed by adding --init option, when image launched.
Co-authored-by: Artem Starshov <artemreyt@tarantool.org>
---
.github/workflows/coverity.yml | 6 +++++-
.github/workflows/debian_11.yml | 1 +
.github/workflows/debug_coverage.yml | 6 +++++-
.github/workflows/luacheck.yml | 6 +++++-
.github/workflows/release.yml | 6 +++++-
.github/workflows/release_asan_clang11.yml | 6 +++++-
.github/workflows/release_clang.yml | 6 +++++-
.github/workflows/release_lto.yml | 6 +++++-
.github/workflows/release_lto_clang11.yml | 6 +++++-
9 files changed, 41 insertions(+), 8 deletions(-)
diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index c8f370033..a265b3dab 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -22,7 +22,11 @@ jobs:
# Image built by .gitlab.mk instructions and targets from .travis.mk.
# Also additional installation of coverity tool installation check
# exists in target deps_coverity_debian at .travis.mk file.
- container: docker.io/tarantool/testing:debian-buster
+ container:
+ image: docker.io/tarantool/testing:debian-buster
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v1
diff --git a/.github/workflows/debian_11.yml b/.github/workflows/debian_11.yml
index 06008c231..84db2644d 100644
--- a/.github/workflows/debian_11.yml
+++ b/.github/workflows/debian_11.yml
@@ -24,6 +24,7 @@ jobs:
submodules: recursive
- name: packaging
env:
+ PACKPACK_EXTRA_DOCKER_RUN_PARAMS: '--init'
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_S3_ENDPOINT_URL: ${{ secrets.AWS_S3_ENDPOINT_URL }}
diff --git a/.github/workflows/debug_coverage.yml b/.github/workflows/debug_coverage.yml
index e671484d7..6787a2e91 100644
--- a/.github/workflows/debug_coverage.yml
+++ b/.github/workflows/debug_coverage.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-stretch
+ container:
+ image: docker.io/tarantool/testing:debian-stretch
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v1
diff --git a/.github/workflows/luacheck.yml b/.github/workflows/luacheck.yml
index 0a5af13b3..511265466 100644
--- a/.github/workflows/luacheck.yml
+++ b/.github/workflows/luacheck.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-stretch
+ container:
+ image: docker.io/tarantool/testing:debian-stretch
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v1
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index ebd85cba3..b6fea6dbc 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-stretch
+ container:
+ image: docker.io/tarantool/testing:debian-stretch
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v1
diff --git a/.github/workflows/release_asan_clang11.yml b/.github/workflows/release_asan_clang11.yml
index a3885bc27..346f9f0ee 100644
--- a/.github/workflows/release_asan_clang11.yml
+++ b/.github/workflows/release_asan_clang11.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-buster
+ container:
+ image: docker.io/tarantool/testing:debian-buster
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v2.3.4
diff --git a/.github/workflows/release_clang.yml b/.github/workflows/release_clang.yml
index a94c8840a..42decd5da 100644
--- a/.github/workflows/release_clang.yml
+++ b/.github/workflows/release_clang.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-stretch
+ container:
+ image: docker.io/tarantool/testing:debian-stretch
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v1
diff --git a/.github/workflows/release_lto.yml b/.github/workflows/release_lto.yml
index c9905f226..526f19974 100644
--- a/.github/workflows/release_lto.yml
+++ b/.github/workflows/release_lto.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-buster
+ container:
+ image: docker.io/tarantool/testing:debian-buster
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v2.3.4
diff --git a/.github/workflows/release_lto_clang11.yml b/.github/workflows/release_lto_clang11.yml
index d57b15f3a..4a10712de 100644
--- a/.github/workflows/release_lto_clang11.yml
+++ b/.github/workflows/release_lto_clang11.yml
@@ -18,7 +18,11 @@ jobs:
fail-fast: false
# image built by .gitlab.mk instructions and targets from .travis.mk
- container: docker.io/tarantool/testing:debian-buster
+ container:
+ image: docker.io/tarantool/testing:debian-buster
+ # We lean on reaping processes by the init process (PID 1)
+ # in tests.
+ options: '--init'
steps:
- uses: actions/checkout@v2.3.4
--
2.28.0
next prev parent reply other threads:[~2020-12-29 16:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 16:25 [Tarantool-patches] [PATCH 0/3] test: -e assert(false) test fixup Artem Starshov
2020-12-29 16:25 ` [Tarantool-patches] [PATCH 1/3] test: tarantool -e test add more details and avoid busy loop Artem Starshov
2020-12-29 16:53 ` Leonid Vasiliev
2020-12-29 20:11 ` Alexander Turenko
2020-12-29 16:25 ` Artem Starshov [this message]
2020-12-29 16:57 ` [Tarantool-patches] [PATCH 2/3] github-ci: add init option for containers Leonid Vasiliev
2020-12-29 18:32 ` Alexander V. Tikhonov
2020-12-29 19:25 ` Alexander Turenko
2020-12-29 16:25 ` [Tarantool-patches] [PATCH 3/3] test: new version for -e assert(false) test Artem Starshov
2020-12-29 17:07 ` Leonid Vasiliev
2020-12-29 20:16 ` Alexander Turenko
2020-12-29 16:45 ` [Tarantool-patches] [PATCH 0/3] test: -e assert(false) test fixup Artem
2020-12-29 17:11 ` Leonid Vasiliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dab8309753f75099b4f4fdf7e8e86e66051f342.1609259010.git.artemreyt@tarantool.org \
--to=artemreyt@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] github-ci: add init option for containers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox