From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: kostja@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [PATCH 02/12] vinyl: make vy_tuple_delete static
Date: Thu, 21 Feb 2019 13:26:02 +0300 [thread overview]
Message-ID: <9c0fdaff76bb4c78327156682bd98dafe62b193c.1550744027.git.vdavydov.dev@gmail.com> (raw)
In-Reply-To: <cover.1550744027.git.vdavydov.dev@gmail.com>
In-Reply-To: <cover.1550744027.git.vdavydov.dev@gmail.com>
It isn't used anywhere outside vy_stmt.c.
---
src/box/vy_stmt.c | 16 ++++++++--------
src/box/vy_stmt.h | 7 -------
2 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/src/box/vy_stmt.c b/src/box/vy_stmt.c
index af5c6408..618e6025 100644
--- a/src/box/vy_stmt.c
+++ b/src/box/vy_stmt.c
@@ -94,14 +94,7 @@ vy_tuple_new(struct tuple_format *format, const char *data, const char *end)
return tuple;
}
-struct tuple_format_vtab vy_tuple_format_vtab = {
- vy_tuple_delete,
- vy_tuple_new,
-};
-
-size_t vy_max_tuple_size = 1024 * 1024;
-
-void
+static void
vy_tuple_delete(struct tuple_format *format, struct tuple *tuple)
{
say_debug("%s(%p)", __func__, tuple);
@@ -119,6 +112,13 @@ vy_tuple_delete(struct tuple_format *format, struct tuple *tuple)
free(tuple);
}
+struct tuple_format_vtab vy_tuple_format_vtab = {
+ vy_tuple_delete,
+ vy_tuple_new,
+};
+
+size_t vy_max_tuple_size = 1024 * 1024;
+
/**
* Allocate a vinyl statement object on base of the struct tuple
* with malloc() and the reference counter equal to 1.
diff --git a/src/box/vy_stmt.h b/src/box/vy_stmt.h
index d131a461..dd1f2460 100644
--- a/src/box/vy_stmt.h
+++ b/src/box/vy_stmt.h
@@ -220,13 +220,6 @@ vy_stmt_set_n_upserts(struct tuple *stmt, uint8_t n)
}
/**
- * Free the tuple of a vinyl space.
- * @pre tuple->refs == 0
- */
-void
-vy_tuple_delete(struct tuple_format *format, struct tuple *tuple);
-
-/**
* Duplicate the statememnt.
*
* @param stmt statement
--
2.11.0
next prev parent reply other threads:[~2019-02-21 10:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:26 [PATCH 00/12] vinyl: do not fill secondary tuples with nulls Vladimir Davydov
2019-02-21 10:26 ` [PATCH 01/12] vinyl: use vy_lsm_env::empty_key where appropriate Vladimir Davydov
2019-02-21 10:59 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` Vladimir Davydov [this message]
2019-02-21 11:00 ` [tarantool-patches] Re: [PATCH 02/12] vinyl: make vy_tuple_delete static Konstantin Osipov
2019-02-21 10:26 ` [PATCH 03/12] key_def: cleanup virtual function initialization Vladimir Davydov
2019-02-21 11:01 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 12:05 ` Vladimir Davydov
2019-02-21 10:26 ` [PATCH 04/12] key_def: move cmp and hash functions declarations to key_def.h Vladimir Davydov
2019-02-21 11:02 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` [PATCH 05/12] vinyl: move vy_tuple_key_contains_null to generic code Vladimir Davydov
2019-02-21 11:02 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` [PATCH 06/12] vinyl: move vy_key_dup " Vladimir Davydov
2019-02-21 11:04 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 11:52 ` Vladimir Davydov
2019-02-21 10:26 ` [PATCH 07/12] vinyl: sanitize full/empty key stmt detection Vladimir Davydov
2019-02-21 11:10 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 12:11 ` Vladimir Davydov
2019-03-01 12:57 ` Vladimir Davydov
2019-02-21 10:26 ` [PATCH 08/12] vinyl: remove optimized comparators Vladimir Davydov
2019-02-21 11:11 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` [PATCH 09/12] vinyl: introduce statement environment Vladimir Davydov
2019-02-21 11:14 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` [PATCH 10/12] vinyl: rename key stmt construction routine Vladimir Davydov
2019-02-21 11:15 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 12:14 ` Vladimir Davydov
2019-02-21 10:26 ` [PATCH 11/12] vinyl: don't use IPROTO_SELECT type for key statements Vladimir Davydov
2019-02-21 11:16 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 10:26 ` [PATCH 12/12] vinyl: do not fill secondary tuples with nulls when decoded Vladimir Davydov
2019-02-21 15:39 ` [PATCH 00/12] vinyl: do not fill secondary tuples with nulls Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0fdaff76bb4c78327156682bd98dafe62b193c.1550744027.git.vdavydov.dev@gmail.com \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 02/12] vinyl: make vy_tuple_delete static' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox