From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/4] introduce indices over UUID
Date: Sun, 5 Apr 2020 23:21:52 +0200 [thread overview]
Message-ID: <9a155caf-a790-7552-8671-8915506fd96e@tarantool.org> (raw)
In-Reply-To: <cover.1585954493.git.sergepetrenko@tarantool.org>
Hi! Thanks for the patchset!
The build fails on your branch in Travis, on Linux with gcc:
https://travis-ci.org/github/tarantool/tarantool/builds/670792910?utm_source=github_status&utm_medium=notification
On 04/04/2020 01:02, Serge Petrenko wrote:
> https://github.com/tarantool/tarantool/issues/4268
> https://github.com/tarantool/tarantool/tree/sp/gh-4268-uuid-type
>
> Serge Petrenko (4):
> decimal: fix comment typo
> uuid: expose additional from_string constructors
> box: add MsgPack encoding/decoding for UUID
> box: introduce indices by UUID
>
> extra/exports | 3 +
> src/box/field_def.c | 66 +++++++++++---
> src/box/field_def.h | 16 ++++
> src/box/key_def.h | 3 +-
> src/box/tuple_compare.cc | 123 +++++++++++++++++++++++++++
> src/box/tuple_format.c | 3 +-
> src/lib/core/CMakeLists.txt | 1 +
> src/lib/core/mp_decimal.h | 2 +-
> src/lib/core/mp_extension_types.h | 2 +
> src/lib/core/mp_uuid.c | 75 ++++++++++++++++
> src/lib/core/mp_uuid.h | 90 ++++++++++++++++++++
> src/lib/core/mpstream.c | 11 +++
> src/lib/core/mpstream.h | 5 ++
> src/lib/msgpuck | 2 +-
> src/lib/uuid/tt_uuid.c | 9 ++
> src/lib/uuid/tt_uuid.h | 53 +++++++++---
> src/lua/msgpack.c | 27 ++++--
> src/lua/msgpackffi.lua | 14 +++
> src/lua/utils.c | 21 ++++-
> src/lua/utils.h | 5 ++
> src/lua/uuid.lua | 9 --
> test/app-tap/lua/serializer_test.lua | 8 ++
> test/app-tap/msgpackffi.test.lua | 3 +-
> test/app/msgpack.result | 21 +++++
> test/app/msgpack.test.lua | 13 +++
> test/app/uuid.result | 2 +-
> test/box/tuple.result | 81 ++++++++++++++++++
> test/box/tuple.test.lua | 25 ++++++
> test/engine/ddl.result | 97 ++++++++++++++++++++-
> test/engine/ddl.test.lua | 42 ++++++++-
> test/engine/gh-4268-uuid.result | 58 +++++++++++++
> test/engine/gh-4268-uuid.test.lua | 30 +++++++
> test/unit/uuid.c | 24 +++++-
> test/unit/uuid.result | 8 +-
> third_party/lua-cjson/lua_cjson.c | 27 ++++--
> third_party/lua-yaml/lyaml.cc | 17 +++-
> 36 files changed, 933 insertions(+), 63 deletions(-)
> create mode 100644 src/lib/core/mp_uuid.c
> create mode 100644 src/lib/core/mp_uuid.h
> create mode 100644 test/engine/gh-4268-uuid.result
> create mode 100644 test/engine/gh-4268-uuid.test.lua
>
next prev parent reply other threads:[~2020-04-05 21:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 23:02 Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 1/4] decimal: fix comment typo Serge Petrenko
2020-04-05 21:22 ` Vladislav Shpilevoy
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 2/4] uuid: expose additional from_string constructors Serge Petrenko
2020-04-05 21:22 ` Vladislav Shpilevoy
2020-04-09 23:46 ` Serge Petrenko
2020-04-10 16:56 ` Vladislav Shpilevoy
2020-04-11 13:35 ` Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 3/4] box: add MsgPack encoding/decoding for UUID Serge Petrenko
2020-04-05 21:26 ` Vladislav Shpilevoy
2020-04-09 23:46 ` Serge Petrenko
2020-04-03 23:02 ` [Tarantool-patches] [PATCH 4/4] box: introduce indices by UUID Serge Petrenko
2020-04-05 21:29 ` Vladislav Shpilevoy
2020-04-09 23:46 ` Serge Petrenko
2020-04-10 16:56 ` Vladislav Shpilevoy
2020-04-05 21:21 ` Vladislav Shpilevoy [this message]
2020-04-09 23:46 ` [Tarantool-patches] [PATCH 0/4] introduce indices over UUID Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a155caf-a790-7552-8671-8915506fd96e@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/4] introduce indices over UUID' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox