From: Chris Sosnin <k.sosnin@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence
Date: Mon, 2 Mar 2020 18:25:15 +0300 [thread overview]
Message-ID: <9E4E5772-52EF-456A-ACDA-1DEA067B0D55@tarantool.org> (raw)
In-Reply-To: <20200302105955.GA43956@tarantool.org>
Hi! Thank you for the review!
> 2 марта 2020 г., в 13:59, Nikita Pettik <korablev@tarantool.org> написал(а):
>
> On 29 Feb 16:43, Vladislav Shpilevoy wrote:
>> LGTM.
>>
>> On 26/02/2020 17:13, Chris Sosnin wrote:
>>> This code is called from C, so it shouldn't throw.
>>>
>>> Closes #4753
>>> ---
>>> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4753-sequence-cpp-exception
>>> issue: https://github.com/tarantool/tarantool/issues/4753
>>>
>
> Patch LGTM as well, but I see that 3 out of 4 runs on travis result in fail:
>
> https://travis-ci.org/tarantool/tarantool/builds/655369924?utm_source=github_status&utm_medium=notification
>
> Are these known failures (box/access etc)?
>
I didn’t rebase the patch, I’m sorry.
This branch doesn’t have the fix for Masha’s patch, where credentials for user weren’t dropped at the and of the test.
Will fix it.
next prev parent reply other threads:[~2020-03-02 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 16:13 Chris Sosnin
2020-02-29 15:43 ` Vladislav Shpilevoy
2020-03-02 10:59 ` Nikita Pettik
2020-03-02 15:25 ` Chris Sosnin [this message]
2020-03-16 13:43 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9E4E5772-52EF-456A-ACDA-1DEA067B0D55@tarantool.org \
--to=k.sosnin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox