From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 4/6] sql: make built-in functions operate on unsigned values Date: Wed, 17 Jul 2019 03:53:04 +0300 [thread overview] Message-ID: <9D090063-9A38-4222-B7EE-559189F2A100@tarantool.org> (raw) In-Reply-To: <c7c539ba-871d-b712-e480-7e44ef1e93f0@tarantool.org> >> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h >> index 2e8ac55e9..976b4486a 100644 >> --- a/src/box/sql/sqlInt.h >> +++ b/src/box/sql/sqlInt.h >> @@ -395,13 +398,13 @@ void >> sql_result_double(sql_context *, double); >> >> void >> -sql_result_int(sql_context *, int); >> +sql_result_uint(sql_context *ctx, uint64_t u_val); >> >> void >> -sql_result_bool(struct sql_context *ctx, bool value); >> +sql_result_int(sql_context *, int64_t); > > 1. Please, do not omit parameter names. > >> diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c >> index 705e869bc..ff7ce658b 100644 >> --- a/src/box/sql/vdbeapi.c >> +++ b/src/box/sql/vdbeapi.c >> @@ -320,21 +330,21 @@ sql_result_double(sql_context * pCtx, double rVal) >> } >> >> void >> -sql_result_int(sql_context * pCtx, int iVal) >> +sql_result_uint(sql_context *ctx, uint64_t u_val) >> { >> - mem_set_i64(pCtx->pOut, iVal); >> + mem_set_u64(ctx->pOut, u_val); >> } >> >> void >> -sql_result_bool(struct sql_context *ctx, bool value) >> +sql_result_int(sql_context * pCtx, int64_t iVal) > > 2. In new code we usually use Tarantool code style - no > spaces after '*', and no camel case. Fixes for both comments: diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h index 976b4486a..3a1a63b22 100644 --- a/src/box/sql/sqlInt.h +++ b/src/box/sql/sqlInt.h @@ -401,7 +401,7 @@ void sql_result_uint(sql_context *ctx, uint64_t u_val); void -sql_result_int(sql_context *, int64_t); +sql_result_int(sql_context *ctx, int64_t val); void sql_result_bool(struct sql_context *ctx, bool value); diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c index ff7ce658b..44f01fb87 100644 --- a/src/box/sql/vdbeapi.c +++ b/src/box/sql/vdbeapi.c @@ -336,9 +336,9 @@ sql_result_uint(sql_context *ctx, uint64_t u_val) } void -sql_result_int(sql_context * pCtx, int64_t iVal) +sql_result_int(sql_context *ctx, int64_t val) { - mem_set_i64(pCtx->pOut, iVal); + mem_set_i64(ctx->pOut, val); } void
next prev parent reply other threads:[~2019-07-17 0:53 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-07 15:37 [tarantool-patches] [PATCH 0/6] Introduce UNSIGNED type in SQL Nikita Pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 1/6] sql: refactor sql_atoi64() Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:20 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:32 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 2/6] sql: separate VDBE memory holding positive and negative ints Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:33 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 3/6] sql: refactor arithmetic operations to support unsigned ints Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-17 12:24 ` n.pettik 2019-06-07 15:37 ` [tarantool-patches] [PATCH 4/6] sql: make built-in functions operate on unsigned values Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-17 0:53 ` n.pettik [this message] 2019-06-07 15:37 ` [tarantool-patches] [PATCH 5/6] sql: introduce extended range for INTEGER type Nikita Pettik 2019-06-11 21:11 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-01 14:21 ` n.pettik 2019-07-01 21:53 ` Vladislav Shpilevoy 2019-07-24 15:59 ` Konstantin Osipov 2019-07-24 16:54 ` n.pettik 2019-07-24 17:09 ` Konstantin Osipov 2019-06-07 15:37 ` [tarantool-patches] [PATCH 6/6] sql: allow to specify UNSIGNED column type Nikita Pettik 2019-07-01 21:53 ` [tarantool-patches] " Vladislav Shpilevoy 2019-07-05 16:36 ` n.pettik 2019-07-10 22:49 ` Vladislav Shpilevoy 2019-07-11 21:25 ` Vladislav Shpilevoy 2019-07-17 0:53 ` n.pettik 2019-07-18 20:18 ` Vladislav Shpilevoy 2019-07-18 20:56 ` n.pettik 2019-07-18 21:08 ` Vladislav Shpilevoy 2019-07-18 21:13 ` Vladislav Shpilevoy 2019-07-22 10:20 ` n.pettik 2019-07-22 19:17 ` Vladislav Shpilevoy 2019-07-22 10:20 ` n.pettik 2019-07-17 0:54 ` n.pettik 2019-07-18 20:18 ` Vladislav Shpilevoy 2019-08-06 19:36 ` n.pettik 2019-07-24 13:01 ` [tarantool-patches] Re: [PATCH 0/6] Introduce UNSIGNED type in SQL Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9D090063-9A38-4222-B7EE-559189F2A100@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH 4/6] sql: make built-in functions operate on unsigned values' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox