From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [RFC PATCH 02/12] recovery: constify vclock argument Date: Wed, 6 Jun 2018 20:45:02 +0300 [thread overview] Message-ID: <99fa9862c17903ace6a6a678a359a4f5a68955cb.1528305232.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1528305232.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1528305232.git.vdavydov.dev@gmail.com> Neither recovery_new() nor recover_remaining_wals() need to modify it. --- src/box/recovery.cc | 6 +++--- src/box/recovery.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/box/recovery.cc b/src/box/recovery.cc index a5e0ad34..cf348d29 100644 --- a/src/box/recovery.cc +++ b/src/box/recovery.cc @@ -102,7 +102,7 @@ struct XlogGapError: public XlogError { */ struct recovery * recovery_new(const char *wal_dirname, bool force_recovery, - struct vclock *vclock) + const struct vclock *vclock) { struct recovery *r = (struct recovery *) calloc(1, sizeof(*r)); @@ -178,7 +178,7 @@ recovery_delete(struct recovery *r) */ static void recover_xlog(struct recovery *r, struct xstream *stream, - struct vclock *stop_vclock) + const struct vclock *stop_vclock) { struct xrow_header row; uint64_t row_count = 0; @@ -238,7 +238,7 @@ recover_xlog(struct recovery *r, struct xstream *stream, */ void recover_remaining_wals(struct recovery *r, struct xstream *stream, - struct vclock *stop_vclock, bool scan_dir) + const struct vclock *stop_vclock, bool scan_dir) { struct vclock *clock; diff --git a/src/box/recovery.h b/src/box/recovery.h index b7e4a312..3a950e47 100644 --- a/src/box/recovery.h +++ b/src/box/recovery.h @@ -63,7 +63,7 @@ struct recovery { struct recovery * recovery_new(const char *wal_dirname, bool force_recovery, - struct vclock *vclock); + const struct vclock *vclock); void recovery_delete(struct recovery *r); @@ -94,6 +94,6 @@ recovery_finalize(struct recovery *r, struct xstream *stream); */ void recover_remaining_wals(struct recovery *r, struct xstream *stream, - struct vclock *stop_vclock, bool scan_dir); + const struct vclock *stop_vclock, bool scan_dir); #endif /* TARANTOOL_RECOVERY_H_INCLUDED */ -- 2.11.0
next prev parent reply other threads:[~2018-06-06 17:45 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-06 17:45 [RFC PATCH 00/12] Replica rejoin Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 01/12] recovery: drop unused recovery_exit Vladimir Davydov 2018-06-08 4:13 ` Konstantin Osipov 2018-06-06 17:45 ` Vladimir Davydov [this message] 2018-06-08 4:14 ` [RFC PATCH 02/12] recovery: constify vclock argument Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 03/12] applier: remove extra new line in log message printed on connect Vladimir Davydov 2018-06-08 4:15 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 04/12] xrow: add helper function for encoding vclock Vladimir Davydov 2018-06-08 4:16 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 05/12] box: retrieve instance uuid before starting local recovery Vladimir Davydov 2018-06-08 4:22 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 06/12] box: refactor hot standby recovery Vladimir Davydov 2018-06-08 4:40 ` Konstantin Osipov 2018-06-08 6:43 ` Vladimir Davydov 2018-06-08 13:15 ` Konstantin Osipov 2018-06-08 13:30 ` Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 07/12] box: retrieve end vclock before starting local recovery Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 08/12] box: open the port " Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 09/12] box: connect to remote peers " Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 10/12] box: factor out local recovery function Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 11/12] applier: inquire oldest vclock on connect Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 12/12] replication: rebootstrap instance on startup if it fell behind Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=99fa9862c17903ace6a6a678a359a4f5a68955cb.1528305232.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [RFC PATCH 02/12] recovery: constify vclock argument' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox