From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>, tarantool-patches@freelists.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] relay: fix join vclock obtainment in relay_initial_join
Date: Wed, 30 Oct 2019 23:22:09 +0100 [thread overview]
Message-ID: <99d1e77d-ad20-dad6-fb8b-1d7180bb4380@tarantool.org> (raw)
In-Reply-To: <20191029212006.23437-1-i.kosarev@tarantool.org>
Hi! Thanks for the patch!
LGTM, except the comment below.
> diff --git a/src/box/wal.h b/src/box/wal.h
> index b76b0a41f..827b0fb85 100644
> --- a/src/box/wal.h
> +++ b/src/box/wal.h
> @@ -182,9 +182,10 @@ wal_mode();
> /**
> * Wait until all submitted writes are successfully flushed
> * to disk. Returns 0 on success, -1 if write failed.
> + * Corresponding vclock is returned in @vclock unless it is NULL.
> */
For parameter reference, please, use '@a <param_name>' syntax,
not '@<param_name>'. See doxygen documentation on @a.
> int
> -wal_sync(void);
> +wal_sync(struct vclock *vclock);
>
next prev parent reply other threads:[~2019-10-30 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 14:23 [Tarantool-patches] [PATCH v3] replication: " Ilya Kosarev
2019-10-29 17:02 ` Konstantin Osipov
2019-10-29 21:20 ` [Tarantool-patches] [PATCH v3] relay: " Ilya Kosarev
2019-10-30 22:22 ` Vladislav Shpilevoy [this message]
2019-11-01 0:35 ` Ilya Kosarev
2019-11-01 0:38 ` Ilya Kosarev
2019-10-29 21:20 ` [Tarantool-patches] [PATCH v3] replication: " Ilya Kosarev
2019-10-30 14:33 ` [Tarantool-patches] [tarantool-patches] " Ilya Kosarev
2019-10-29 15:20 [Tarantool-patches] [PATCH v3] relay: " Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d1e77d-ad20-dad6-fb8b-1d7180bb4380@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [PATCH v3] relay: fix join vclock obtainment in relay_initial_join' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox