Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] memtx: allow quota overuse for truncation
Date: Tue, 22 Dec 2020 14:28:30 +0100	[thread overview]
Message-ID: <99a08336-665b-6973-33e8-b49e44dc7d74@tarantool.org> (raw)
In-Reply-To: <1608574523.582576002@f340.i.mail.ru>

>     Also I don't understand why can't you do that on the slab arena
>     level. Start allocating only 'huge' slabs if the quota is full, but
>     disabled.
> Yes, allocation in case of out of quota can be done on more
> internal level.
> But the problem is exactly in freeing you mentioned further.
> We need to free in the right way: If we are allocating with
> mempool, we need to use mempool_find() properly, while
> if we are allocating ‘huge’ slab, we need to free it accordingly.
> So the information about the allocation has to be stored
> somehow in case we are going to alter it depending on the
> current state. I don’t see convenient place where we can store
> it, looks like it will be even worse to store such information
> in struct tuple itself.

I don't understand why do you need to store any info. Huge slabs
existed and were freed before your patch, and all worked fine here.
How are they found and freed with quota enabled?

  reply	other threads:[~2020-12-22 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 15:37 Ilya Kosarev
2020-12-14 23:41 ` Vladislav Shpilevoy
2020-12-16 23:43   ` Ilya Kosarev
2020-12-20 16:13     ` Vladislav Shpilevoy
2020-12-21 18:15       ` Ilya Kosarev
2020-12-22 13:28         ` Vladislav Shpilevoy [this message]
2020-12-22 14:14           ` Ilya Kosarev
2020-12-22 14:22             ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99a08336-665b-6973-33e8-b49e44dc7d74@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] memtx: allow quota overuse for truncation' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox