From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Ilya Kosarev <i.kosarev@tarantool.org>, alyapunov@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] memtx: allow quota overuse for truncation Date: Tue, 15 Dec 2020 00:41:54 +0100 [thread overview] Message-ID: <3f0e3d86-17a4-9356-bffe-079308c46e05@tarantool.org> (raw) In-Reply-To: <20201211153724.7575-1-i.kosarev@tarantool.org> Thanks for the patch! See 2 comments below. On 11.12.2020 16:37, Ilya Kosarev wrote: > Trying to perform space:truncate() while reaching memtx_memory limit > we could experience slab allocator failure. This behavior seems to be > quite surprising for users. Now we are allowing to overuse memtx quota > for tuples in space _truncate using flag in struct quota. > Truncate tuples are only being allocated with large slabs using malloc > so that the quota can shrink back when they are freed. 1. 3807 is also about delete. Why didn't you patch it too? AFAIR, the fix I proposed was easy - in case something inside memtx_space_execute_delete() fails due to OOM, we disable quota, try again, and enable quota. In fact, it would be even simpler than the truncation fix, I suppose. > Closes #3807 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3807-safe-alloc-on-truncation > Issue: https://github.com/tarantool/tarantool/issues/3807 > > diff --git a/src/box/memtx_space.c b/src/box/memtx_space.c > index 73b4c450eb..cc431ea816 100644 > --- a/src/box/memtx_space.c > +++ b/src/box/memtx_space.c > @@ -327,8 +327,9 @@ memtx_space_execute_replace(struct space *space, struct txn *txn, > struct memtx_space *memtx_space = (struct memtx_space *)space; > struct txn_stmt *stmt = txn_current_stmt(txn); > enum dup_replace_mode mode = dup_replace_mode(request->type); > - stmt->new_tuple = memtx_tuple_new(space->format, request->tuple, > - request->tuple_end); > + stmt->new_tuple = space->format->vtab.tuple_new(space->format, > + request->tuple, > + request->tuple_end); 2. Seems like an expensive change. You added +2 pointer dereferences to a hot path. Last time when you worked on that I proposed to make space_truncate use box.begin + quota disable + box_upsert + quota enable + commit. So there are no yields between quota enable and disable. And no changes in the code not related to truncation. Why didn't it work? > if (stmt->new_tuple == NULL) > return -1; > tuple_ref(stmt->new_tuple);
next prev parent reply other threads:[~2020-12-14 23:41 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-11 15:37 Ilya Kosarev 2020-12-14 23:41 ` Vladislav Shpilevoy [this message] 2020-12-16 23:43 ` Ilya Kosarev 2020-12-20 16:13 ` Vladislav Shpilevoy 2020-12-21 18:15 ` Ilya Kosarev 2020-12-22 13:28 ` Vladislav Shpilevoy 2020-12-22 14:14 ` Ilya Kosarev 2020-12-22 14:22 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3f0e3d86-17a4-9356-bffe-079308c46e05@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alyapunov@tarantool.org \ --cc=i.kosarev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] memtx: allow quota overuse for truncation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox