From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql
Date: Fri, 27 Jul 2018 13:14:12 +0300 [thread overview]
Message-ID: <98f23458-6018-038e-12fe-c9f03bd332d5@tarantool.org> (raw)
In-Reply-To: <a0d89298-b5d4-e60d-eb8a-fdb7aad8db1c@tarantool.org>
LGTM.
On 27/07/2018 13:02, Kirill Shcherbatov wrote:
>
>
> On 27.07.2018 11:55, Vladislav Shpilevoy wrote:
>> Hi! I do not see your answer. You've just sent empty email with my cite.
>>
>> On 27/07/2018 10:13, Kirill Shcherbatov wrote:
>>>> Thanks for the fixes! I have pushed my own on the branch.
>>>> Please, squash.
>>>>
>>>> Sorry, I was wrong about txn != NULL omitting. If we omit it,
>>>> then for ephemeral spaces we do not start ro stmt, but commit
>>>> it. It is not correct.
>>>>
>>>> Your code works only because commit_ro() is no-op when we
>>>> have an active transaction. But it can change in futureThank you for review. I've squashed this changes.
> Oh, sorry. It is kind of misunderstanding. Maybe I've press Enter on selected text before send via Ctrl+Enter.Thank you for review. I've squashed your changes.
>
next prev parent reply other threads:[~2018-07-27 10:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 13:52 [tarantool-patches] [PATCH v1 1/1] " Kirill Shcherbatov
2018-07-20 15:03 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-20 17:50 ` Kirill Shcherbatov
2018-07-23 11:50 ` Vladislav Shpilevoy
2018-07-23 16:20 ` n.pettik
2018-07-23 16:39 ` Vladislav Shpilevoy
2018-07-23 17:09 ` n.pettik
2018-07-23 17:21 ` Vladislav Shpilevoy
2018-07-23 18:06 ` n.pettik
2018-07-23 18:29 ` Vladislav Shpilevoy
2018-07-24 11:05 ` [tarantool-patches] [PATCH v1 1/2] sql: use schema API to get index info in analyze Kirill Shcherbatov
[not found] ` <cover.1532430181.git.kshcherbatov@tarantool.org>
2018-07-24 11:05 ` [tarantool-patches] [PATCH v1 2/2] sql: prevent executing crossengine sql Kirill Shcherbatov
2018-07-25 13:24 ` [tarantool-patches] " n.pettik
2018-07-25 17:07 ` Kirill Shcherbatov
2018-07-25 21:05 ` Vladislav Shpilevoy
2018-07-26 7:08 ` Kirill Shcherbatov
2018-07-26 8:54 ` Vladislav Shpilevoy
2018-07-26 11:22 ` Kirill Shcherbatov
2018-07-26 21:26 ` Vladislav Shpilevoy
2018-07-27 7:13 ` Kirill Shcherbatov
2018-07-27 8:55 ` Vladislav Shpilevoy
2018-07-27 10:02 ` Kirill Shcherbatov
2018-07-27 10:14 ` Vladislav Shpilevoy [this message]
2018-07-31 7:54 ` Kirill Yukhin
2018-07-25 13:22 ` [tarantool-patches] Re: [PATCH v1 1/2] sql: use schema API to get index info in analyze n.pettik
2018-07-25 17:07 ` Kirill Shcherbatov
2018-07-25 20:52 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98f23458-6018-038e-12fe-c9f03bd332d5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing crossengine sql' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox