From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 21/25] vinyl: add function to create surrogate deletes from raw msgpack Date: Fri, 27 Jul 2018 14:30:01 +0300 [thread overview] Message-ID: <98cbebff047fe0a9674d959fa6a769ad5517a804.1532689066.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1532689065.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1532689065.git.vdavydov.dev@gmail.com> Currently, there's only vy_stmt_new_surrogate_delete(), which takes a tuple. Let's add vy_stmt_new_surrogate_delete_raw(), which takes raw msgpack data. Needed for #2129 --- src/box/vy_stmt.c | 7 +++---- src/box/vy_stmt.h | 12 +++++++++++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/box/vy_stmt.c b/src/box/vy_stmt.c index 09daa7f4..f4c3dd18 100644 --- a/src/box/vy_stmt.c +++ b/src/box/vy_stmt.c @@ -388,11 +388,10 @@ vy_stmt_new_surrogate_delete_from_key(const char *key, } struct tuple * -vy_stmt_new_surrogate_delete(struct tuple_format *format, - const struct tuple *src) +vy_stmt_new_surrogate_delete_raw(struct tuple_format *format, + const char *src_data, const char *src_data_end) { - uint32_t src_size; - const char *src_data = tuple_data_range(src, &src_size); + uint32_t src_size = src_data_end - src_data; uint32_t total_size = src_size + format->field_map_size; /* Surrogate tuple uses less memory than the original tuple */ char *data = region_alloc(&fiber()->gc, total_size); diff --git a/src/box/vy_stmt.h b/src/box/vy_stmt.h index 878a27f7..273d5e84 100644 --- a/src/box/vy_stmt.h +++ b/src/box/vy_stmt.h @@ -496,8 +496,18 @@ vy_stmt_new_surrogate_delete_from_key(const char *key, * @retval NULL Memory or fields format error. */ struct tuple * +vy_stmt_new_surrogate_delete_raw(struct tuple_format *format, + const char *data, const char *data_end); + +/** @copydoc vy_stmt_new_surrogate_delete_raw. */ +static inline struct tuple * vy_stmt_new_surrogate_delete(struct tuple_format *format, - const struct tuple *tuple); + const struct tuple *tuple) +{ + uint32_t size; + const char *data = tuple_data_range(tuple, &size); + return vy_stmt_new_surrogate_delete_raw(format, data, data + size); +} /** * Create the REPLACE statement from raw MessagePack data. -- 2.11.0
next prev parent reply other threads:[~2018-07-27 11:30 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-27 11:29 [PATCH 00/25] vinyl: eliminate disk read on REPLACE/DELETE Vladimir Davydov 2018-07-27 11:29 ` [PATCH 01/25] vinyl: make point lookup always return the latest tuple version Vladimir Davydov 2018-07-27 11:29 ` [PATCH 02/25] vinyl: simplify vy_squash_process Vladimir Davydov 2018-07-27 11:29 ` [PATCH 03/25] vinyl: always get full tuple from pk after reading from secondary index Vladimir Davydov 2018-07-27 11:29 ` [PATCH 04/25] vinyl: fold vy_replace_one and vy_replace_impl Vladimir Davydov 2018-07-27 11:29 ` [PATCH 05/25] vinyl: fold vy_delete_impl Vladimir Davydov 2018-07-27 11:29 ` [PATCH 06/25] vinyl: refactor unique check Vladimir Davydov 2018-07-27 11:29 ` [PATCH 07/25] vinyl: check key uniqueness before modifying tx write set Vladimir Davydov 2018-07-27 11:29 ` [PATCH 08/25] vinyl: remove env argument of vy_check_is_unique_{primary,secondary} Vladimir Davydov 2018-07-31 20:45 ` [tarantool-patches] " Konstantin Osipov 2018-07-27 11:29 ` [PATCH 09/25] vinyl: store full tuples in secondary index cache Vladimir Davydov 2018-07-31 20:47 ` Konstantin Osipov 2018-07-27 11:29 ` [PATCH 10/25] vinyl: do not free pending tasks on shutdown Vladimir Davydov 2018-07-31 20:48 ` Konstantin Osipov 2018-07-27 11:29 ` [PATCH 11/25] vinyl: store pointer to scheduler in struct vy_task Vladimir Davydov 2018-07-31 20:49 ` Konstantin Osipov 2018-07-27 11:29 ` [PATCH 12/25] vinyl: rename some members of vy_scheduler and vy_task struct Vladimir Davydov 2018-07-27 11:29 ` [PATCH 13/25] vinyl: use cbus for communication between scheduler and worker threads Vladimir Davydov 2018-07-27 11:29 ` [PATCH 14/25] vinyl: zap vy_scheduler::is_worker_pool_running Vladimir Davydov 2018-07-27 11:29 ` [PATCH 15/25] vinyl: rename vy_task::status to is_failed Vladimir Davydov 2018-07-27 11:29 ` [PATCH 16/25] xrow: allow to store flags in DML requests Vladimir Davydov 2018-07-27 11:29 ` [PATCH 17/25] vinyl: pin last statement returned by write iterator explicitly Vladimir Davydov 2018-07-27 11:29 ` [PATCH 18/25] vinyl: teach write iterator to return overwritten tuples Vladimir Davydov 2018-07-27 11:29 ` [PATCH 19/25] vinyl: prepare write iterator heap comparator for deferred DELETEs Vladimir Davydov 2018-07-27 11:30 ` [PATCH 20/25] vinyl: allow to skip certain statements on read Vladimir Davydov 2018-07-27 11:30 ` Vladimir Davydov [this message] 2018-07-27 11:30 ` [PATCH 22/25] vinyl: remove pointless assertion from vy_stmt_new_surrogate_delete Vladimir Davydov 2018-07-27 11:30 ` [PATCH 23/25] txn: add helper to detect transaction boundaries Vladimir Davydov 2018-07-31 20:52 ` [tarantool-patches] " Konstantin Osipov 2018-07-27 11:30 ` [PATCH 24/25] Introduce _vinyl_deferred_delete system space Vladimir Davydov 2018-07-31 20:54 ` Konstantin Osipov 2018-08-01 14:00 ` Vladimir Davydov 2018-08-01 20:25 ` [tarantool-patches] " Konstantin Osipov 2018-08-02 9:43 ` Vladimir Davydov 2018-08-06 8:42 ` Vladimir Davydov 2018-07-27 11:30 ` [PATCH 25/25] vinyl: eliminate disk read on REPLACE/DELETE Vladimir Davydov 2018-07-31 20:55 ` Konstantin Osipov 2018-08-01 16:03 ` Vladimir Davydov 2018-08-01 16:51 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=98cbebff047fe0a9674d959fa6a769ad5517a804.1532689066.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 21/25] vinyl: add function to create surrogate deletes from raw msgpack' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox