From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] box: make UUID part of SCALAR
Date: Fri, 21 May 2021 21:09:45 +0200 [thread overview]
Message-ID: <9894dc5a-50d0-32f9-badf-8c13375e7171@tarantool.org> (raw)
In-Reply-To: <7db92f114edfe61c8c3ca6d00e082ac0e6063be9.1621157404.git.imeevma@gmail.com>
Hi! Thanks for the patch!
> diff --git a/test/app/uuid.result b/test/app/uuid.result
> index b4870302e..c085f9b6d 100644
> --- a/test/app/uuid.result
> +++ b/test/app/uuid.result
> @@ -443,6 +443,64 @@ u1_str = nil
<...>
> +--
> +-- Make sure that comparison in right. Comparison in SCALAR field:
in -> is
> +-- bool < number < string < varbinary < uuid.
> +--
The rest is LGTM. Send it to a second reviewer right away.
next prev parent reply other threads:[~2021-05-21 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 9:31 Mergen Imeev via Tarantool-patches
2021-05-19 10:48 ` Mergen Imeev via Tarantool-patches
2021-05-21 19:09 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-05-24 9:49 ` Kirill Yukhin via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2021-04-23 11:40 Mergen Imeev via Tarantool-patches
2021-04-25 9:07 ` Serge Petrenko via Tarantool-patches
2021-04-26 15:31 ` Mergen Imeev via Tarantool-patches
2021-04-28 14:43 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9894dc5a-50d0-32f9-badf-8c13375e7171@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] box: make UUID part of SCALAR' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox