From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 028396C1AE; Fri, 21 May 2021 22:09:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 028396C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621624190; bh=66sWxCB/zpc/ygLUILkb3gJ+6LqhOT5Ezp8k7JW94hA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OlsKzvBEs6iz7Izi513TPAIuK+ffdpM7hdDpaQqQ+V+5Q46uS45hSg7covhfdFCiJ iCWhqlegnhx33HJKd0dLN5MwVIIe60XP4dRifTsLcxtZEBdtbnU7zFgxuqj9TvXjv7 DPMVRikNuvxxKXLx1xoVPSDli7P/lHphLQrA9dFY= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6B11B6C1AE for ; Fri, 21 May 2021 22:09:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B11B6C1AE Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lkAWo-0004dT-Iv; Fri, 21 May 2021 22:09:47 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <7db92f114edfe61c8c3ca6d00e082ac0e6063be9.1621157404.git.imeevma@gmail.com> Message-ID: <9894dc5a-50d0-32f9-badf-8c13375e7171@tarantool.org> Date: Fri, 21 May 2021 21:09:45 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <7db92f114edfe61c8c3ca6d00e082ac0e6063be9.1621157404.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AF6F63A46F26EE68FD6CF19A7203B0589400894C459B0CD1B90DDA619F39B201898D3F951AB79EDC2987D0FBB1434CAE8C4A548FA9AF445804 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE762F001A90027CA0CC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE72DF3470F92485B86EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D404D5F8DA949DF20DD99D3CF92422A166A1CC7F00164DA146DAFE8445B8C89999728AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC87BD21ED50D08CA4DF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50BCF7819B169CC96A3042F13F4A32C2E9365D03389F06201D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346EDE9E12965E8CD50527EFAD2A7520EE39D2CFAB0E80676C0527621649FCCE752C277B46989DF53E1D7E09C32AA3244C2D1BC307A3FB7EF84CFBEECA8877805760759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3CIvDNz8QqA/skIh5QGGbA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228F3352BC540A5C72D3A4E3E86351CC1A3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] box: make UUID part of SCALAR X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > diff --git a/test/app/uuid.result b/test/app/uuid.result > index b4870302e..c085f9b6d 100644 > --- a/test/app/uuid.result > +++ b/test/app/uuid.result > @@ -443,6 +443,64 @@ u1_str = nil <...> > +-- > +-- Make sure that comparison in right. Comparison in SCALAR field: in -> is > +-- bool < number < string < varbinary < uuid. > +-- The rest is LGTM. Send it to a second reviewer right away.