From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Oleg Piskunov <o.piskunov@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1] build: fix build after commit 7b443650 Date: Fri, 17 Apr 2020 17:09:47 +0300 [thread overview] Message-ID: <977f51a8cf1df83bebd3d0f0db79749ef5351a42.1587132510.git.avtikhon@tarantool.org> (raw) Found that some package builds failed on the mistake in CMakeLists.txt file, the failed packages and test builds were: - CentOS 6 - CentOS 7 - Ubuntu 14.04 and static build based on Dockerfile. The core of the issue appeared to be single backslash instead of double at the comment in CMakeLists.txt file, which should pass the cmake syntax rules. Follow up #3308 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3308-fix-commit-full-ci src/box/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/CMakeLists.txt b/src/box/CMakeLists.txt index 5ed7eaead..d4abccc82 100644 --- a/src/box/CMakeLists.txt +++ b/src/box/CMakeLists.txt @@ -3,7 +3,7 @@ file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/src/box/lua) # Sometimes 'spying' code is not acceptable even if it would be # disabled by default. That option allows to remove the feedback # daemon from the build completely. -option(ENABLE_FEEDBACK_DAEMON "Feedback daemon which reports debug data to \ +option(ENABLE_FEEDBACK_DAEMON "Feedback daemon which reports debug data to \\ the Tarantool team" ON) add_subdirectory(sql) -- 2.17.1
next reply other threads:[~2020-04-17 14:09 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-17 14:09 Alexander V. Tikhonov [this message] 2020-04-18 3:15 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=977f51a8cf1df83bebd3d0f0db79749ef5351a42.1587132510.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] build: fix build after commit 7b443650' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox