From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org Subject: [tarantool-patches] [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h Date: Sun, 29 Apr 2018 01:45:10 +0300 [thread overview] Message-ID: <974e5a841431ec8b25124030c3ce4a9113279d10.1524955403.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: <cover.1524955403.git.v.shpilevoy@tarantool.org> In-Reply-To: <cover.1524955403.git.v.shpilevoy@tarantool.org> The issue #3290 was not only about upper/lower Lua functions, but about unicode comparison functions too. Actually, the issue requests upper/lower exactly to do string comparison, that can be done more quick with no garbage strings creation. For this Tarantool collations can be used. To be able to expose collations into Lua, the coll.h/.c, coll_def.h/.c and coll_cache.h/.c must be moved from 'box' static library into 'core' static library so that they will be built together with string utils. But they require 'stat' and 'box_error' libraries. The patch prepares the files going to be moved, so in the next patch they are just moved, with no changes. It saves commit history. --- src/box/error.cc | 1 - src/box/error.h | 12 ++++++++++++ src/box/schema.h | 12 ------------ 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/box/error.cc b/src/box/error.cc index 99f519537..4bab5d720 100644 --- a/src/box/error.cc +++ b/src/box/error.cc @@ -174,7 +174,6 @@ BuildXlogError(const char *file, unsigned line, const char *format, ...) } } -#include "schema.h" #include "trigger.h" struct rlist on_access_denied = RLIST_HEAD_INITIALIZER(on_access_denied); diff --git a/src/box/error.h b/src/box/error.h index c791e6c6a..69a1022ad 100644 --- a/src/box/error.h +++ b/src/box/error.h @@ -133,6 +133,18 @@ extern const struct type_info type_ClientError; extern const struct type_info type_XlogError; extern const struct type_info type_AccessDeniedError; +/** + * Context passed to on_access_denied trigger. + */ +struct on_access_denied_ctx { + /** Type of declined access */ + const char *access_type; + /** Type of object the required access was denied to */ + const char *object_type; + /** Name of object the required access was denied to */ + const char *object_name; +}; + #if defined(__cplusplus) } /* extern "C" */ #include "exception.h" diff --git a/src/box/schema.h b/src/box/schema.h index 56f39b3fe..4b2a3da4e 100644 --- a/src/box/schema.h +++ b/src/box/schema.h @@ -224,16 +224,4 @@ extern struct rlist on_alter_sequence; */ extern struct rlist on_access_denied; -/** - * Context passed to on_access_denied trigger. - */ -struct on_access_denied_ctx { - /** Type of declined access */ - const char *access_type; - /** Type of object the required access was denied to */ - const char *object_type; - /** Name of object the required access was denied to */ - const char *object_name; -}; - #endif /* INCLUDES_TARANTOOL_BOX_SCHEMA_H */ -- 2.15.1 (Apple Git-101)
next prev parent reply other threads:[~2018-04-28 22:45 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-28 22:45 [tarantool-patches] [PATCH v2 0/5] Expose ICU into Lua Vladislav Shpilevoy 2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 1/5] alter: fix assertion in collations alter Vladislav Shpilevoy 2018-04-28 22:45 ` Vladislav Shpilevoy [this message] 2018-05-04 11:06 ` [tarantool-patches] Re: [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h Alexander Turenko 2018-05-04 12:05 ` Vladislav Shpilevoy 2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 3/5] Merge box_error, stat and collations into core library Vladislav Shpilevoy 2018-05-04 11:36 ` [tarantool-patches] " Alexander Turenko 2018-05-04 12:05 ` Vladislav Shpilevoy 2018-05-08 13:18 ` Konstantin Osipov 2018-05-10 21:06 ` Vladislav Shpilevoy 2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 4/5] Always store built-in collations in the cache Vladislav Shpilevoy 2018-05-08 13:20 ` [tarantool-patches] " Konstantin Osipov 2018-04-28 22:45 ` [tarantool-patches] [PATCH v2 5/5] lua: introduce utf8 built-in globaly visible module Vladislav Shpilevoy 2018-05-04 22:33 ` [tarantool-patches] " Alexander Turenko 2018-05-04 23:32 ` Vladislav Shpilevoy 2018-05-05 0:18 ` Alexander Turenko 2018-05-05 0:24 ` Vladislav Shpilevoy 2018-05-05 0:38 ` Alexander Turenko 2018-05-05 0:45 ` Vladislav Shpilevoy 2018-05-08 13:21 ` Konstantin Osipov 2018-05-05 0:19 ` [tarantool-patches] Re: [PATCH v2 0/5] Expose ICU into Lua Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=974e5a841431ec8b25124030c3ce4a9113279d10.1524955403.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2 2/5] Move struct on_access_denied_ctx into error.h' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox