From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: "n.pettik" <korablev@tarantool.org>, Tarantool MailList <tarantool-patches@freelists.org> Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: restrict nullable action definitions Date: Thu, 19 Jul 2018 11:12:54 +0300 [thread overview] Message-ID: <972c8144-0f4c-c882-3ab9-4a50cbaf43c6@tarantool.org> (raw) In-Reply-To: <51802451-C9AA-4EB8-8926-D08446738FF1@tarantool.org> > This name sounds really weird.. Why not sql_column_add_nullable_action ? If you wish. -sql_column_nullable_action_add(struct Parse *parser, +sql_column_add_nullable_action(struct Parse *parser, > Why do you need on_conflict_action_MAX when you already have ON_CONFLICT_ACTION_DEFAULT? > Anyway, there is no action DEFAULT, it is sooner or later converted to ABORT. This is the central idea of the patch. on_conflict_action_MAX is a marker that this field wasn't initialized yet manually. This allows to detect second attempt to specify NULL/NOT NULL etc. There is a comment about this concept in sqlite3AddColumn where on_conflict_action_MAX is set. The default behavior is ON_CONFLICT_ACTION_NONE and we have to distinguish non-initialized columns and initialized with ON_CONFLICT_ACTION_DEFAULT. > Could we avoid using iPKey in this function? We are going to remove it soon. I don't increase a complexity here and believe that is patch is not about to suggest a way to exclude iPkey. No idea. - sqlite3TokenInit(&ipkToken, pTab->def->fields[pTab->iPKey].name); + struct field_def *field = &fields[pTab->iPKey]; > Lets write ‘can’t be declared with NULL’. Otherwise, it seems to be confusing. --- gh-3473: Primary key can be declared with NULL. +-- gh-3473: Primary key can't be declared with NULL.
next prev parent reply other threads:[~2018-07-19 8:12 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-18 16:52 [tarantool-patches] [PATCH v1 0/3] " Kirill Shcherbatov 2018-07-18 16:52 ` [tarantool-patches] [PATCH v1 1/3] " Kirill Shcherbatov 2018-07-18 20:12 ` [tarantool-patches] " n.pettik 2018-07-19 8:12 ` Kirill Shcherbatov [this message] 2018-07-20 2:39 ` n.pettik 2018-07-20 7:29 ` Kirill Shcherbatov 2018-07-23 8:31 ` Kirill Shcherbatov 2018-07-23 16:53 ` Kirill Shcherbatov 2018-07-23 19:27 ` n.pettik 2018-07-18 16:52 ` [tarantool-patches] [PATCH v1 2/3] sql: fixed possible leak in sqlite3EndTable Kirill Shcherbatov 2018-07-18 20:12 ` [tarantool-patches] " n.pettik 2018-07-18 16:52 ` [tarantool-patches] [PATCH v1 3/3] sql: get rid of Column structure Kirill Shcherbatov 2018-07-18 20:13 ` [tarantool-patches] " n.pettik 2018-07-19 8:12 ` Kirill Shcherbatov 2018-07-19 8:39 ` Vladislav Shpilevoy 2018-07-19 10:17 ` Kirill Shcherbatov 2018-07-20 2:43 ` n.pettik 2018-07-24 15:26 ` [tarantool-patches] Re: [PATCH v1 0/3] sql: restrict nullable action definitions Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=972c8144-0f4c-c882-3ab9-4a50cbaf43c6@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/3] sql: restrict nullable action definitions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox