Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
	tarantool-patches@freelists.org,
	Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: refactor vdbe_emit_open_cursor calls
Date: Tue, 10 Jul 2018 19:52:38 +0300	[thread overview]
Message-ID: <970a2e70-c5f5-fac7-cf7b-2e7f0c6d7cce@tarantool.org> (raw)
In-Reply-To: <4ebd4fc9-6ab9-13bc-6cbe-2f42a5025da3@tarantool.org>

Thanks for the squash. I have force pushed some comment
style violation fixes.

Nikita, please, do a second review.

On 10/07/2018 19:37, Kirill Shcherbatov wrote:
>> Maybe it is more convenient, but it is not more correct. Your
>> first commit still does not fix the mess with index_id/tnum.
>>
>> Please, squash it into your first commit.
> Ok, I've done this.
> 

  reply	other threads:[~2018-07-10 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 12:42 [tarantool-patches] " Kirill Shcherbatov
2018-07-10 11:48 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-10 13:44   ` Kirill Shcherbatov
2018-07-10 14:59     ` Vladislav Shpilevoy
2018-07-10 15:45       ` Kirill Shcherbatov
2018-07-10 15:56         ` Vladislav Shpilevoy
2018-07-10 16:37           ` Kirill Shcherbatov
2018-07-10 16:52             ` Vladislav Shpilevoy [this message]
2018-07-10 13:45 ` [tarantool-patches] [PATCH v1 2/2] sql: remove OP_LoadPtr Kirill Shcherbatov
2018-07-10 14:59   ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=970a2e70-c5f5-fac7-cf7b-2e7f0c6d7cce@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: refactor vdbe_emit_open_cursor calls' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox