Re: [Tarantool-patches] [PATCH v2 5/6] sql: extend result set with autoincrement

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi!

Yes, first 5 patches are good to push.

On 25/12/2019 13:17, Nikita Pettik wrote:
> On 24 Dec 16:30, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> I've pushed my review fix on top of this commit. See it below
>> and on the branch.
> 
> Thanks, I've squashed your review fixes. Are the rest of patches
> (except last one) LGTM? If so, I'd like to push them to focus on
> the last.
>  
>> commit 53fd4b3b3a27cf99c6c7a71a085574b2fd8a0dc7
>> Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
>> Date:   Tue Dec 24 15:56:24 2019 +0100
>>
>>     Review fix 5/6
>>
>> diff --git a/src/box/sql/select.c b/src/box/sql/select.c
>> index ddb2509f4..a19494ed9 100644
>> --- a/src/box/sql/select.c
>> +++ b/src/box/sql/select.c
>> @@ -1847,7 +1847,7 @@ generate_column_metadata(struct Parse *pParse, struct SrcList *pTabList,
>>  				vdbe_metadata_set_col_nullability(v, i,
>>  								  is_nullable);
>>  				if (space->sequence != NULL &&
>> -				    space->sequence_fieldno == iCol)
>> +				    space->sequence_fieldno == (uint32_t) iCol)
>>  					vdbe_metadata_set_col_autoincrement(v, i);
>>  			}
>>  		} else {