From: Alex Khatskevich <avkhatskevich@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 1/3] Add test on error during reconfigure
Date: Thu, 19 Jul 2018 23:33:20 +0300 [thread overview]
Message-ID: <95eccf6c-67fc-d9a5-f3d7-a5b276d1ea88@tarantool.org> (raw)
In-Reply-To: <069d5b60-cffa-c24c-06f9-9a9af1af8fcb@tarantool.org>
>> +-- Check that data has at least all fields as an ethalon.
>
> 1. Typo here and in other places: ethalon -> etalon.
Fixed
>
> 2. Please, describe the function in doxygen style since
> it is not a trival one-liner.
Added, however, the comment is bigger than the function...
>> +...
>> +err:match('Error injection:.*')
>
> 3. P l e a s e. Again. Do not use pcall + match. Use
> util.check_error.
Ok. Sorry. It is a very old commit.
next prev parent reply other threads:[~2018-07-19 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 17:47 [tarantool-patches] [PATCH 0/3] vshard reload mechanism AKhatskevich
2018-07-18 17:47 ` [tarantool-patches] [PATCH 1/3] Add test on error during reconfigure AKhatskevich
2018-07-19 15:14 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-19 20:33 ` Alex Khatskevich [this message]
2018-07-20 11:34 ` Alex Khatskevich
2018-07-20 14:15 ` Vladislav Shpilevoy
2018-07-18 17:47 ` [tarantool-patches] [PATCH 2/3] Complete module reload AKhatskevich
2018-07-19 15:14 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-19 20:32 ` Alex Khatskevich
2018-07-20 11:34 ` Alex Khatskevich
2018-07-20 14:15 ` Vladislav Shpilevoy
2018-07-18 17:47 ` [tarantool-patches] [PATCH 3/3] Introduce storage reload evolution AKhatskevich
2018-07-19 15:14 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-20 11:32 ` Alex Khatskevich
2018-07-20 14:15 ` Vladislav Shpilevoy
2018-07-20 23:58 ` Alex Khatskevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95eccf6c-67fc-d9a5-f3d7-a5b276d1ea88@tarantool.org \
--to=avkhatskevich@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 1/3] Add test on error during reconfigure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox