From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH 07/18] vinyl: tune dump bandwidth histogram buckets Date: Thu, 16 Aug 2018 19:12:01 +0300 [thread overview] Message-ID: <950c240800e03ac28cdbca904cb7679663ed36bc.1534432819.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1534432819.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1534432819.git.vdavydov.dev@gmail.com> Typically, dump bandwidth varies from 10 MB to 100 MB per second so let's use 5 MB bucket granularity in this range. Values less than 10 MB/s can also be observed, because the user can limit disk rate with box.cfg.snap_io_rate_limit so use 1 MB granularity between 1 MB and 10 MB and 100 KB granularity between 100 KB and 1 MB. A write rate greater than 100 MB/s is unlikely in practice, even on very fast disks, since dump bandwidth is also limited by CPU, so use 100 MB granularity there. --- src/box/vy_quota.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/box/vy_quota.c b/src/box/vy_quota.c index 8cea4deb..99da69ae 100644 --- a/src/box/vy_quota.c +++ b/src/box/vy_quota.c @@ -105,19 +105,16 @@ vy_quota_timer_cb(ev_loop *loop, ev_timer *timer, int events) int vy_quota_create(struct vy_quota *q, vy_quota_exceeded_f quota_exceeded_cb) { - enum { KB = 1000, MB = 1000 * 1000 }; + enum { KB = 1024, MB = KB * KB }; static int64_t dump_bandwidth_buckets[] = { - 100 * KB, 200 * KB, 300 * KB, 400 * KB, 500 * KB, - 1 * MB, 2 * MB, 3 * MB, 4 * MB, 5 * MB, - 10 * MB, 20 * MB, 30 * MB, 40 * MB, 50 * MB, - 60 * MB, 70 * MB, 80 * MB, 90 * MB, 100 * MB, - 110 * MB, 120 * MB, 130 * MB, 140 * MB, 150 * MB, - 160 * MB, 170 * MB, 180 * MB, 190 * MB, 200 * MB, - 220 * MB, 240 * MB, 260 * MB, 280 * MB, 300 * MB, - 320 * MB, 340 * MB, 360 * MB, 380 * MB, 400 * MB, - 450 * MB, 500 * MB, 550 * MB, 600 * MB, 650 * MB, - 700 * MB, 750 * MB, 800 * MB, 850 * MB, 900 * MB, - 950 * MB, 1000 * MB, + 100 * KB, 200 * KB, 300 * KB, 400 * KB, 500 * KB, 600 * KB, + 700 * KB, 800 * KB, 900 * KB, 1 * MB, 2 * MB, 3 * MB, + 4 * MB, 5 * MB, 6 * MB, 7 * MB, 8 * MB, 9 * MB, + 10 * MB, 15 * MB, 20 * MB, 25 * MB, 30 * MB, 35 * MB, + 40 * MB, 45 * MB, 50 * MB, 55 * MB, 60 * MB, 65 * MB, + 70 * MB, 75 * MB, 80 * MB, 85 * MB, 90 * MB, 95 * MB, + 100 * MB, 200 * MB, 300 * MB, 400 * MB, 500 * MB, 600 * MB, + 700 * MB, 800 * MB, 900 * MB, }; q->dump_bw = histogram_new(dump_bandwidth_buckets, -- 2.11.0
next prev parent reply other threads:[~2018-08-16 16:12 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-16 16:11 [PATCH 00/18] Implement write throttling for vinyl Vladimir Davydov 2018-08-16 16:11 ` [PATCH 01/18] vinyl: rework internal quota API Vladimir Davydov 2018-08-20 11:07 ` Konstantin Osipov 2018-08-24 8:32 ` Vladimir Davydov 2018-08-27 18:29 ` Vladimir Davydov 2018-08-16 16:11 ` [PATCH 02/18] vinyl: move quota methods implementation to vy_quota.c Vladimir Davydov 2018-08-20 11:07 ` Konstantin Osipov 2018-08-27 18:30 ` Vladimir Davydov 2018-08-16 16:11 ` [PATCH 03/18] vinyl: move quota related methods and variables from vy_env to vy_quota Vladimir Davydov 2018-08-20 11:08 ` Konstantin Osipov 2018-08-27 18:33 ` Vladimir Davydov 2018-08-16 16:11 ` [PATCH 04/18] vinyl: implement vy_quota_wait using vy_quota_try_use Vladimir Davydov 2018-08-20 11:09 ` Konstantin Osipov 2018-08-27 18:36 ` Vladimir Davydov 2018-08-16 16:11 ` [PATCH 05/18] vinyl: wake up fibers waiting for quota one by one Vladimir Davydov 2018-08-20 11:11 ` Konstantin Osipov 2018-08-24 8:33 ` Vladimir Davydov 2018-08-28 13:19 ` Vladimir Davydov 2018-08-28 14:04 ` Konstantin Osipov 2018-08-28 14:39 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 06/18] vinyl: do not wake up fibers waiting for quota if quota is unavailable Vladimir Davydov 2018-08-20 11:13 ` Konstantin Osipov 2018-08-16 16:12 ` Vladimir Davydov [this message] 2018-08-20 11:15 ` [PATCH 07/18] vinyl: tune dump bandwidth histogram buckets Konstantin Osipov 2018-08-28 15:37 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 08/18] vinyl: rename vy_quota::dump_bw to dump_bw_hist Vladimir Davydov 2018-08-20 11:15 ` Konstantin Osipov 2018-08-28 16:04 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 09/18] vinyl: cache dump bandwidth for timer invocation Vladimir Davydov 2018-08-20 11:21 ` Konstantin Osipov 2018-08-28 16:10 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 10/18] vinyl: do not add initial guess to dump bandwidth histogram Vladimir Davydov 2018-08-20 11:23 ` Konstantin Osipov 2018-08-23 20:15 ` Konstantin Osipov 2018-08-28 16:15 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 11/18] vinyl: use snap_io_rate_limit for initial dump bandwidth estimate Vladimir Davydov 2018-08-20 11:24 ` Konstantin Osipov 2018-08-24 8:31 ` Vladimir Davydov 2018-08-28 16:18 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 12/18] histogram: add function for computing lower bound percentile estimate Vladimir Davydov 2018-08-20 11:29 ` [tarantool-patches] " Konstantin Osipov 2018-08-24 8:30 ` Vladimir Davydov 2018-08-28 16:39 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 13/18] vinyl: use lower bound percentile estimate for dump bandwidth Vladimir Davydov 2018-08-28 16:51 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 14/18] vinyl: do not try to trigger dump if it is already in progress Vladimir Davydov 2018-08-16 16:12 ` [PATCH 15/18] vinyl: improve dump start/stop logging Vladimir Davydov 2018-08-23 20:18 ` Konstantin Osipov 2018-08-16 16:12 ` [PATCH 16/18] vinyl: confine quota watermark within sane value range Vladimir Davydov 2018-08-16 16:12 ` [PATCH 17/18] vinyl: set quota timer period to 100 ms Vladimir Davydov 2018-08-23 20:49 ` Konstantin Osipov 2018-08-24 8:18 ` Vladimir Davydov 2018-08-16 16:12 ` [PATCH 18/18] vinyl: throttle tx rate if dump does not catch up Vladimir Davydov 2018-08-23 20:54 ` Konstantin Osipov 2018-08-23 20:58 ` [tarantool-patches] " Konstantin Osipov 2018-08-24 8:21 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=950c240800e03ac28cdbca904cb7679663ed36bc.1534432819.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 07/18] vinyl: tune dump bandwidth histogram buckets' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox