Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl

[lvasiliev <lvasiliev@tarantool.org>]

Hi! Thanks for the reviews.

On 10.04.2020 3:00, Vladislav Shpilevoy wrote:
> Hi!
> 
> Thanks for the patchset!
> 
> LGTM.
> 
> But please, next time don't silently respond with a new patch
> on my comments. I may be wrong sometimes. Honestly I am wrong
> quite often. Like Vladimir said once, "mailing list exists for
> discussions".
> 
OK
> I added Yaroslav to CC since he expressed a will to join the
> review.
> 
> On 09/04/2020 08:33, Leonid Vasiliev wrote:
>> https://github.com/tarantool/tarantool/issues/4629
>> https://github.com/tarantool/luarocks/tree/lvasiliev/gh-4629-add-chdir-to-make
>> See corresponding patch for tarantoolctl
>> (https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4629-forward-flags)
>>
>> Motivation:
>> Imperfect integretion of the Luarocks to tarantoolctl
>> (malfunctioning flags, disabled commands)
>>
>> Was done:
>> whitelist of tarantoolctl don't used for luarocks flags
>> Option chdir has been moved from tarantoolctl to luarocks
>>
>> @ChangeLog - see a comment in tarantool
>>
>> Leonid Vasiliev (2):
>>    Add the chdir option for make
>>    Delete flags which can't be used with tarantoolctl rocks
>>
>>   src/luarocks/cmd/help.lua | 5 -----
>>   src/luarocks/cmd/make.lua | 8 ++++++++
>>   src/luarocks/util.lua     | 5 +----
>>   3 files changed, 9 insertions(+), 9 deletions(-)
>>