From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3642-misc-* test
Date: Mon, 7 Sep 2020 09:48:10 +0300 [thread overview]
Message-ID: <93df91c8f9e41013155ceec70b62d7c3a25a4c79.1599461246.git.avtikhon@tarantool.org> (raw)
On heavy loaded hosts found the following issue:
[036] --- replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.result Sun Sep 6 23:49:57 2020
[036] +++ replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.reject Mon Sep 7 04:07:06 2020
[036] @@ -63,7 +63,7 @@
[036] ...
[036] box.info.replication[1].upstream.status
[036] ---
[036] -- follow
[036] +- disconnected
[036] ...
[036] test_run:cmd('switch default')
[036] ---
It happened because replication upstream status check occurred too
early, when it was only in 'disconnected' state. To give the
replication status check routine ability to reach the needed 'follow'
state, it need to wait for it using test_run:wait_upstream() routine.
Closes #5276
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4940-replication-misc
Issue: https://github.com/tarantool/tarantool/issues/5276
.../gh-3642-misc-no-socket-leak-on-replica-disconnect.result | 4 ++--
...gh-3642-misc-no-socket-leak-on-replica-disconnect.test.lua | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.result b/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.result
index d068ad8fc..e2adb3bc3 100644
--- a/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.result
+++ b/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.result
@@ -61,9 +61,9 @@ test_run:cmd("setopt delimiter ''");
---
- true
...
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
---
-- follow
+- true
...
test_run:cmd('switch default')
---
diff --git a/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.test.lua b/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.test.lua
index 9cfbe7214..ac26aa314 100644
--- a/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.test.lua
+++ b/test/replication/gh-3642-misc-no-socket-leak-on-replica-disconnect.test.lua
@@ -28,7 +28,7 @@ for i = 1, 64 do
end;
test_run:cmd("setopt delimiter ''");
-box.info.replication[1].upstream.status
+test_run:wait_upstream(1, {status = 'follow'})
test_run:cmd('switch default')
--
2.17.1
next reply other threads:[~2020-09-07 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 6:48 Alexander V. Tikhonov [this message]
2020-09-09 15:41 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93df91c8f9e41013155ceec70b62d7c3a25a4c79.1599461246.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3642-misc-* test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox