[tarantool-patches] Re: [PATCH v3 4/4] netbox: introduce iterable future objects

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

On 07/06/2018 15:56, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/06/02 02:09]:
>> Netbox has two major ways to execute a request: sync and async.
>> During execution of any a server can send multiplie responses via
>> IPROTO_CHUNK. And the execution ways differ in how to handle the
>> chunks (called messages or pushes).
> 
> Please don't use asserts. They are hell to debug. Please use
> tap suite if you need to check things, or simple output the result
> you expect.

I have removed assertions and use output checking.

> 
> The patch itself looks good to me. Did you send a message to
> docbot about the new API?
> 

Yes, I have already created docbot request. But I do not agree with
the API, when push by default is taken from session.sync. If you want
make the sync be optional, we must either

* make it mandatory, fix box.session.sync()/introduce fiber_sync()/something
   else, then allow to omit sync;

Or

* fix sync and then commit box.session.push with optional sync. Or with no
   sync, and allow it when somebody asks.