From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES
Date: Sat, 29 Dec 2018 15:35:00 +0200 [thread overview]
Message-ID: <92C91EEB-6934-40C4-96C2-46487F97A697@tarantool.org> (raw)
In-Reply-To: <855d85cccdd7e33aa4b49988c5165512d5fa94ad.1546079994.git.kshcherbatov@tarantool.org>
>
> +/** Callback to forward and error from mpstream methods. */
> +static inline void
> +mpstream_encode_error(void *error_ctx)
> +{
> + *(bool *)error_ctx = true;
> +}
Is this artefact after previous patch?
> +/**
> + * Perform encoding memory variable to stream.
> + * @param stream Initialized mpstream encoder object.
> + * @param var Vdbe memory variable to encode with stream.
> + */
> +void
> +mpstream_encode_vdbe_mem(struct mpstream *stream, struct Mem *var);
> +
The same question.
The rest is Ok now.
I didn’t carefully check test fixes tho, only looked through, since they
consist of monotonic changes, but I believe you did it :)
next prev parent reply other threads:[~2018-12-29 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 10:48 [tarantool-patches] [PATCH v2 0/5] " Kirill Shcherbatov
2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 1/5] sql: clean-up vdbe_emit_constraint_checks Kirill Shcherbatov
2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 2/5] sql: fix sql_vdbe_mem_alloc_region result memory Kirill Shcherbatov
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 3/5] sql: fix fkey exception for self-referenced table Kirill Shcherbatov
2018-12-29 13:26 ` [tarantool-patches] " n.pettik
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run Kirill Shcherbatov
2018-12-29 13:26 ` [tarantool-patches] " n.pettik
2018-12-29 15:28 ` Kirill Shcherbatov
2019-01-09 12:29 ` n.pettik
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov
2018-12-29 13:35 ` n.pettik [this message]
2018-12-29 15:31 ` [tarantool-patches] " Kirill Shcherbatov
2019-01-10 12:30 ` [tarantool-patches] Re: [PATCH v2 0/5] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92C91EEB-6934-40C4-96C2-46487F97A697@tarantool.org \
--to=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox