From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 03/10] cmake: add option ENABLE_UB_SANITIZER
Date: Sat, 30 May 2020 00:36:19 +0200 [thread overview]
Message-ID: <9257939d-1791-a4ee-0c56-d0f27e30c398@tarantool.org> (raw)
In-Reply-To: <20200529085324.GA74017@pony.bronevichok.ru>
Hi! Thanks for the comment!
On 29/05/2020 10:53, Sergey Bronnikov wrote:
> Vlad,
>
> thanks for the patch!
>
> On 01:32 Thu 28 May , Vladislav Shpilevoy wrote:
>
> <snipped>
>
>> diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake
>> index ce3e7e506..373bcd3b0 100644
>> --- a/cmake/compiler.cmake
>> +++ b/cmake/compiler.cmake
>> @@ -238,6 +238,8 @@ endif()
>>
>> option(ENABLE_WERROR "Make all compiler warnings into errors" OFF)
>>
>> +option(ENABLE_UB_SANITIZER "Make the compiler generate runtime code to perform undefined behaviour checks" OFF)
>
> It would be useful to add ENABLE_UB_SANITIZER option to a list "options"
> in a root CMakeLists.txt. cmake shows options from this list and it's
> status at the end of output.
I didn't even know that the option list existed, nice. Added:
====================
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1d80b6806..e49317f8a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -571,7 +571,7 @@ set(PREFIX ${CMAKE_INSTALL_PREFIX})
set(options PACKAGE VERSION BUILD C_COMPILER CXX_COMPILER C_FLAGS CXX_FLAGS
PREFIX
ENABLE_SSE2 ENABLE_AVX
- ENABLE_GCOV ENABLE_GPROF ENABLE_VALGRIND ENABLE_ASAN
+ ENABLE_GCOV ENABLE_GPROF ENABLE_VALGRIND ENABLE_ASAN ENABLE_UB_SANITIZER
ENABLE_BACKTRACE
ENABLE_DOC
ENABLE_DIST
next prev parent reply other threads:[~2020-05-29 22:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 23:32 [Tarantool-patches] [PATCH v2 00/10] Sanitize unaligned access Vladislav Shpilevoy
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 01/10] small: sanitized rlist and new region API Vladislav Shpilevoy
2020-05-28 20:41 ` Timur Safin
2020-05-28 22:56 ` Vladislav Shpilevoy
2020-06-08 23:01 ` Vladislav Shpilevoy
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 10/10] xrow: use unaligned store operation in xrow_to_iovec() Vladislav Shpilevoy
2020-05-28 20:20 ` Timur Safin
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 02/10] cmake: ignore warnings on alignof() and offsetof() Vladislav Shpilevoy
2020-05-28 20:18 ` Timur Safin
2020-05-29 6:24 ` Kirill Yukhin
2020-05-29 22:34 ` Vladislav Shpilevoy
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 03/10] cmake: add option ENABLE_UB_SANITIZER Vladislav Shpilevoy
2020-05-28 20:42 ` Timur Safin
2020-05-29 8:53 ` Sergey Bronnikov
2020-05-29 22:36 ` Vladislav Shpilevoy [this message]
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 04/10] crc32: align memory access Vladislav Shpilevoy
2020-05-28 20:11 ` Timur Safin
2020-05-28 23:23 ` Vladislav Shpilevoy
2020-05-28 23:32 ` Timur Safin
2020-06-08 22:33 ` Vladislav Shpilevoy
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 05/10] sql: make BtCursor's memory aligned Vladislav Shpilevoy
2020-05-28 20:20 ` Timur Safin
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 06/10] region: use aligned allocations where necessary Vladislav Shpilevoy
2020-05-28 20:35 ` Timur Safin
2020-05-28 23:07 ` Vladislav Shpilevoy
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 07/10] vinyl: align statements and bps tree extents Vladislav Shpilevoy
2020-05-28 20:38 ` Timur Safin
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 08/10] tuple: use unaligned store-load for field map Vladislav Shpilevoy
2020-05-28 20:22 ` Timur Safin
2020-05-27 23:32 ` [Tarantool-patches] [PATCH v2 09/10] port: make port_c_entry not PACKED Vladislav Shpilevoy
2020-05-28 20:42 ` Timur Safin
2020-06-03 21:27 ` [Tarantool-patches] [PATCH v2 00/10] Sanitize unaligned access Vladislav Shpilevoy
2020-06-08 22:33 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9257939d-1791-a4ee-0c56-d0f27e30c398@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 03/10] cmake: add option ENABLE_UB_SANITIZER' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox