From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement
Date: Thu, 28 Nov 2019 23:41:52 +0100 [thread overview]
Message-ID: <9229bfa1-f516-5072-320b-9ab197a03da0@tarantool.org> (raw)
In-Reply-To: <659c12232934c069ae8d71ed1e2bc8115d36f6e0.1574846892.git.korablev@tarantool.org>
Thanks for the patch!
On 27/11/2019 13:15, Nikita Pettik wrote:
> If result set contains column which features attached sequence
> (AUTOINCREMENT in terms of SQL) then meta-information will contain
> corresponding field ('autoicrement' : boolean) in response.
1. Please, lets name all booleans values with 'is_' prefix:
is_autoincrement, IPROTO_FIELD_IS_AUTOINCREMENT.
> diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
> index 0e54e42a5..63afb8777 100644
> --- a/src/box/sql/vdbeInt.h
> +++ b/src/box/sql/vdbeInt.h
> @@ -355,6 +355,8 @@ struct sql_column_metadata {
> * columns: all other expressions are nullable by default.
> */
> int8_t nullable : 2;
> + /** True if column features autoincrement property. */
> + int8_t actoincrement : 1;
2. Lets make it bool, and name is_autoincrement.
> };
>
> /*
next prev parent reply other threads:[~2019-11-28 22:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 12:15 [Tarantool-patches] [PATCH 0/6] sql: extend response metadata Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 1/6] sql: refactor resulting set metadata Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:39 ` Nikita Pettik
2019-12-05 23:58 ` Vladislav Shpilevoy
2019-12-06 12:48 ` Nikita Pettik
2019-12-17 13:23 ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 2/6] sql: fix possible null dereference in sql_expr_coll() Nikita Pettik
2019-11-28 22:42 ` Vladislav Shpilevoy
2019-12-05 11:40 ` Nikita Pettik
2019-12-05 23:59 ` Vladislav Shpilevoy
2019-12-06 12:48 ` Nikita Pettik
2019-12-17 13:30 ` Sergey Ostanevich
2019-12-17 14:44 ` Nikita Pettik
2019-12-17 19:53 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 3/6] sql: extend result set with collation Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:50 ` Nikita Pettik
2019-12-18 11:08 ` Sergey Ostanevich
2019-12-24 0:44 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 4/6] sql: extend result set with nullability Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:50 ` Nikita Pettik
2019-12-06 0:00 ` Vladislav Shpilevoy
2019-12-06 12:49 ` Nikita Pettik
2019-12-18 13:31 ` Sergey Ostanevich
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy [this message]
2019-12-05 11:51 ` Nikita Pettik
2019-12-18 15:17 ` Sergey Ostanevich
2019-12-24 0:47 ` Nikita Pettik
2019-11-27 12:15 ` [Tarantool-patches] [PATCH 6/6] sql: extend result set with alias Nikita Pettik
2019-11-28 22:41 ` Vladislav Shpilevoy
2019-12-05 11:51 ` Nikita Pettik
2019-12-06 0:02 ` Vladislav Shpilevoy
2019-12-06 12:50 ` Nikita Pettik
2019-12-06 21:52 ` Vladislav Shpilevoy
2019-12-19 15:17 ` Sergey Ostanevich
2019-12-24 0:27 ` Nikita Pettik
2019-11-28 22:55 ` [Tarantool-patches] [PATCH 0/6] sql: extend response metadata Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9229bfa1-f516-5072-320b-9ab197a03da0@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox