Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Ivan Koptelov <ivan.koptelov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: raise err on CHECK + ON CONFLICT REPLACE
Date: Mon, 4 Feb 2019 18:28:40 +0300	[thread overview]
Message-ID: <91846D24-DD2B-4658-A309-1EAB34B7631D@tarantool.org> (raw)
In-Reply-To: <20190204144414.91752-1-ivan.koptelov@tarantool.org>



> On 4 Feb 2019, at 17:44, Ivan Koptelov <ivan.koptelov@tarantool.org> wrote:
> 
> Adds error raise in case of CHECK constraint declared with ON
> CONFLICT REPLACE action. Before the patch such option was
> forbidden, but if a user tried to create space with such constraint,
> this attempt failed silently.
> 

What is more, now all on conflict actions are ignored for check
constraints. So lets simply fix parser to disallow this clause.
It is quite easy: all you need is to remove onconf rule after CHECK
keyword:

   319	tcons ::= CHECK LP expr(E) RP onconf.
   320	                                 {sql_add_check_constraint(pParse,&E);}

  reply	other threads:[~2019-02-04 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 14:44 [tarantool-patches] " Ivan Koptelov
2019-02-04 15:28 ` n.pettik [this message]
     [not found] <821d032b-9adf-6496-c0bc-f0f9497c5f83@tarantool.org>
2019-02-04 17:05 ` [tarantool-patches] " Ivan Koptelov
2019-02-05 13:44   ` n.pettik
2019-02-08 14:22   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91846D24-DD2B-4658-A309-1EAB34B7631D@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=ivan.koptelov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: raise err on CHECK + ON CONFLICT REPLACE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox