Re: [Tarantool-patches] [PATCH v2 3/5] error: Increase the number of fields transmitted through IPROTO

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the fixes!

>>> diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
>>> index 07fa54c..1e0cd7a 100644
>>> --- a/src/box/lua/net_box.lua
>>> +++ b/src/box/lua/net_box.lua
>>> @@ -287,7 +289,24 @@ local function create_transport(host, port, user, password, callback,
>>>                       local error = self.response[i]
>>>                       local code = error[IPROTO_ERROR_CODE]
>>>                       local msg = error[IPROTO_ERROR_MESSAGE]
>>> -                    local new_err = box.error.new({code = code, reason = msg})
>>> +                    local custom_type = error[IPROTO_ERROR_CUSTOM_TYPE]
>>> +                    local traceback = error[IPROTO_ERROR_TRACEBACK]
> After we decided don't concatenate the traceback, I decided that it would be inconsistent to transmit the traceback in the case of "throw" over the network, since when creating a new error, the "trace" is set new and it always has been. Furthermore, an error can change the type. So, I delete IPROTO_ERROR_TRACEBACK.If you consider it wrong decision, I can return IPROTO_ERROR_TRACEBACK.

I am ok with that. As I said, traceback is not really a kind of
critical and stable feature anyway.