From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org> Cc: Mons Anderson <v.perepelitsa@corp.mail.ru> Subject: Re: [Tarantool-patches] [PATCH v3 4/4] cfg: configure crash report sending Date: Sat, 5 Dec 2020 19:34:20 +0100 [thread overview] Message-ID: <90d006bf-99ca-17bd-85cb-d5575dbe875f@tarantool.org> (raw) In-Reply-To: <20201204153003.175555-5-gorcunov@gmail.com> Thanks for the patch! See 4 comments below. On 04.12.2020 16:30, Cyrill Gorcunov via Tarantool-patches wrote: > Introcude a new option to box.cfg{} to control sending 1. Introcude -> Introduce. > of a crash report. > > There is no simple way to test all this because it involves > subsequent runs of tarantool. I've been using one terminal > with tarantool running inside as > >> box.cfg{feedback_host="127.0.0.1:1500"} > > another terminal to listen for incoming data > >> while true ; do nc -l -p 1500 -c 'echo -e "HTTP/1.1 200 OK\n\n $(date)"'; done > > and one another to kill main tarantool instance > >> kill -11 `pidof tarantool` > > If we run as > >> box.cfg{feedback_host="127.0.0.1:1500", feedback_no_crashinfo=true} > > then the crash report will not be sent. > > Closes #5261 > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> > > @TarantoolBot document > Title: Configuration reference 2. Please, be more specific. I guess about 80% of all doc tickets are about configuration update. > Header: Feedback 3. What is 'Header:'? Docbot does not parse anything except Title. > For better analisys of program crashes the information associated with > the crash such as > > - utsname (similar to `uname -a` output except the network name) > - build information > - reason for a crash > - call backtrace > > is sent to the feedback server. To disable it set `feedback_no_crashinfo` > to `false`. > --- > src/box/lua/feedback_daemon.lua | 7 +++++++ > src/box/lua/load_cfg.lua | 3 +++ > src/lib/core/errstat.c | 2 +- > test/box/admin.result | 2 ++ > test/box/cfg.result | 4 ++++ > 5 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua > index 1d39012ed..613d2864c 100644 > --- a/src/box/lua/feedback_daemon.lua > +++ b/src/box/lua/feedback_daemon.lua > @@ -360,12 +361,18 @@ local function reload(self) > self:start() > end > > +ffi.cdef[[ > +void > +cfg_errstat_set_params(void); 4. You must add this function to exports.h, otherwise it may be deleted by some optimization, like it happened to other functions and entire modules before.
next prev parent reply other threads:[~2020-12-05 18:34 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 15:29 [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Cyrill Gorcunov 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer Cyrill Gorcunov 2020-12-05 18:30 ` Vladislav Shpilevoy 2020-12-05 18:52 ` Cyrill Gorcunov 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 2/4] errstat: add crash report base code Cyrill Gorcunov 2020-12-05 18:33 ` Vladislav Shpilevoy 2020-12-05 19:58 ` Cyrill Gorcunov 2020-12-06 15:50 ` Vladislav Shpilevoy 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 3/4] crash: use errstat code in fatal signals Cyrill Gorcunov 2020-12-05 18:33 ` Vladislav Shpilevoy 2020-12-05 20:04 ` Cyrill Gorcunov 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 4/4] cfg: configure crash report sending Cyrill Gorcunov 2020-12-05 18:34 ` Vladislav Shpilevoy [this message] 2020-12-05 18:30 ` [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=90d006bf-99ca-17bd-85cb-d5575dbe875f@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.perepelitsa@corp.mail.ru \ --subject='Re: [Tarantool-patches] [PATCH v3 4/4] cfg: configure crash report sending' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox