From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer Date: Fri, 4 Dec 2020 18:30:00 +0300 [thread overview] Message-ID: <20201204153003.175555-2-gorcunov@gmail.com> (raw) In-Reply-To: <20201204153003.175555-1-gorcunov@gmail.com> This will allow to reuse this routine in crash reports. Part-of #5261 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/lib/core/backtrace.cc | 12 ++++++------ src/lib/core/backtrace.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc index 456ce9a4d..68d0d3ee6 100644 --- a/src/lib/core/backtrace.cc +++ b/src/lib/core/backtrace.cc @@ -131,7 +131,7 @@ get_proc_name(unw_cursor_t *unw_cur, unw_word_t *offset, bool skip_cache) } char * -backtrace(void) +backtrace(char *start, char *end) { int frame_no = 0; unw_word_t sp = 0, old_sp = 0, ip, offset; @@ -139,10 +139,8 @@ backtrace(void) unw_getcontext(&unw_context); unw_cursor_t unw_cur; unw_init_local(&unw_cur, &unw_context); - char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE); - char *p = backtrace_buf; - char *end = p + SMALL_STATIC_SIZE - 1; int unw_status; + char *p = start; *p = '\0'; while ((unw_status = unw_step(&unw_cur)) > 0) { const char *proc; @@ -174,7 +172,7 @@ backtrace(void) say_debug("unwinding error: %i", unw_status); #endif out: - return backtrace_buf; + return start; } /* @@ -436,7 +434,9 @@ backtrace_foreach(backtrace_cb cb, coro_context *coro_ctx, void *cb_ctx) void print_backtrace(void) { - fdprintf(STDERR_FILENO, "%s", backtrace()); + char *start = (char *)static_alloc(SMALL_STATIC_SIZE); + char *end = start + SMALL_STATIC_SIZE - 1; + fdprintf(STDERR_FILENO, "%s", backtrace(start, end)); } #endif /* ENABLE_BACKTRACE */ diff --git a/src/lib/core/backtrace.h b/src/lib/core/backtrace.h index c119d5402..55489c01b 100644 --- a/src/lib/core/backtrace.h +++ b/src/lib/core/backtrace.h @@ -40,6 +40,9 @@ extern "C" { #ifdef ENABLE_BACKTRACE #include <coro.h> +char * +backtrace(char *start, char *end); + void print_backtrace(void); typedef int (backtrace_cb)(int frameno, void *frameret, -- 2.26.2
next prev parent reply other threads:[~2020-12-04 15:30 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 15:29 [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Cyrill Gorcunov 2020-12-04 15:30 ` Cyrill Gorcunov [this message] 2020-12-05 18:30 ` [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer Vladislav Shpilevoy 2020-12-05 18:52 ` Cyrill Gorcunov 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 2/4] errstat: add crash report base code Cyrill Gorcunov 2020-12-05 18:33 ` Vladislav Shpilevoy 2020-12-05 19:58 ` Cyrill Gorcunov 2020-12-06 15:50 ` Vladislav Shpilevoy 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 3/4] crash: use errstat code in fatal signals Cyrill Gorcunov 2020-12-05 18:33 ` Vladislav Shpilevoy 2020-12-05 20:04 ` Cyrill Gorcunov 2020-12-04 15:30 ` [Tarantool-patches] [PATCH v3 4/4] cfg: configure crash report sending Cyrill Gorcunov 2020-12-05 18:34 ` Vladislav Shpilevoy 2020-12-05 18:30 ` [Tarantool-patches] [PATCH v3 0/4] crash dump: implement sending feedback Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201204153003.175555-2-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.perepelitsa@corp.mail.ru \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 1/4] backtrace: allow to specify destination buffer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox