From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] test: rework box/misc test part regarding on_shutdown triggers
Date: Fri, 12 Apr 2019 17:35:24 +0300 [thread overview]
Message-ID: <90480C3B-12BD-4B8E-9D8B-A1C887EAFBB1@tarantool.org> (raw)
In-Reply-To: <20190412142057.3aa6v6ib3toupu2o@esperanza>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
> 12 апр. 2019 г., в 17:20, Vladimir Davydov <vdavydov.dev@gmail.com> написал(а):
>
> On Fri, Apr 12, 2019 at 05:12:11PM +0300, Serge Petrenko wrote:
>>>> test_run:cmd("switch default")
>>>> +test_run:eval("test", "_ = fiber.new(function() os.exit() while true do end end)")
>>>
>>> This is supposed to stop the default instance?!
>>
>> No, it’s evaled on ’test’, which is the other instance. And that’s why we need the require(‘fiber’) above.
>> Anyways, will split the patch in two and resend.
>
> Missed the eval, sorry.
It’s ok.
I’ve resent the patch. Please see '[PATCH v2 0/2] Rework on_shutdown test for better stability.'
[-- Attachment #2: Type: text/html, Size: 1445 bytes --]
prev parent reply other threads:[~2019-04-12 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 13:37 Serge Petrenko
2019-04-12 14:00 ` Vladimir Davydov
2019-04-12 14:12 ` [tarantool-patches] " Serge Petrenko
2019-04-12 14:20 ` Vladimir Davydov
2019-04-12 14:35 ` Serge Petrenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90480C3B-12BD-4B8E-9D8B-A1C887EAFBB1@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH] test: rework box/misc test part regarding on_shutdown triggers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox