From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, imeevma@tarantool.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] app: example.lua does not start
Date: Thu, 16 Aug 2018 23:58:03 +0300 [thread overview]
Message-ID: <90212d19-59e8-8778-a86b-803ae4663ff9@tarantool.org> (raw)
In-Reply-To: <577c0a6a34b9ed0c41d84257bae3da0bcaffec19.1534419170.git.imeevma@gmail.com>
Hi! Thanks for the patch! LGTM. I have pushed the patch into 2.0.
On 16/08/2018 14:35, imeevma@tarantool.org wrote:
> According to #3072 log_nonblock cannot be used in
> given case. This patch set this option to "false".
>
> Closes #3348
> ---
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3348-example-lua-does-not-start
> Issue: https://github.com/tarantool/tarantool/issues/3348
>
> extra/dist/example.lua | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/extra/dist/example.lua b/extra/dist/example.lua
> index 0aa51c6..153d831 100644
> --- a/extra/dist/example.lua
> +++ b/extra/dist/example.lua
> @@ -136,7 +136,7 @@ box.cfg {
>
> -- If true, tarantool does not block on the log file descriptor
> -- when it’s not ready for write, and drops the message instead
> - log_nonblock = true;
> + log_nonblock = false;
>
> -- If processing a request takes longer than
> -- the given value (in seconds), warn about it in the log
>
prev parent reply other threads:[~2018-08-16 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 11:35 [tarantool-patches] " imeevma
2018-08-16 20:58 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90212d19-59e8-8778-a86b-803ae4663ff9@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] app: example.lua does not start' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox