From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition
Date: Thu, 13 Jul 2023 12:58:44 +0300 [thread overview]
Message-ID: <8f2e48d3-3a13-c9f1-46fa-836df321db8b@tarantool.org> (raw)
In-Reply-To: <73e2376cd179a89d8be7c0a277e6cab3fecb95bd.1689184997.git.imun@tarantool.org>
Hi, Igor!
Thanks for the patch! LGTM
On 7/12/23 21:06, Igor Munkin wrote:
> As a result of branch renaming in LuaJIT repository, the existing job
> concurrency group definition rule has become outdated. This patch
> updates the condition according to the new branch naming policy.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>
> Branch: https://github.com/tarantool/luajit/tree/imun/ci-update-job-concurrency-group-def
>
> .github/workflows/exotic-builds-testing.yml | 12 +++++-------
> .github/workflows/gnumake-builds-testing.yml | 12 +++++-------
> .github/workflows/lint.yml | 12 +++++-------
> .github/workflows/testing.yml | 12 +++++-------
> 4 files changed, 20 insertions(+), 28 deletions(-)
>
> diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
> index 2269928f..318fb4dd 100644
> --- a/.github/workflows/exotic-builds-testing.yml
> +++ b/.github/workflows/exotic-builds-testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml
> index b78823f1..afb96183 100644
> --- a/.github/workflows/gnumake-builds-testing.yml
> +++ b/.github/workflows/gnumake-builds-testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index 71ceee9a..70c98104 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
> diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
> index 8300c443..2c637124 100644
> --- a/.github/workflows/testing.yml
> +++ b/.github/workflows/testing.yml
> @@ -11,8 +11,8 @@ on:
> concurrency:
> # An update of a developer branch cancels the previously
> # scheduled workflow run for this branch. However, the default
> - # branch, and long-term branch (tarantool-1.10, tarantool-2.8,
> - # etc.) workflow runs are never canceled.
> + # branch, and long-term branch (tarantool/release/2.11,
> + # tarantool/release/2.10, etc) workflow runs are never canceled.
> #
> # We use a trick here: define the concurrency group as 'workflow
> # run ID' + # 'workflow run attempt' because it is a unique
> @@ -21,11 +21,9 @@ concurrency:
> # XXX: we cannot use `github.sha` as a unique identifier because
> # pushing a tag may cancel a run that works on a branch push
> # event.
> - group: ${{ (
> - github.ref == 'refs/heads/tarantool' ||
> - startsWith(github.ref, 'refs/heads/tarantool-')) &&
> - format('{0}-{1}', github.run_id, github.run_attempt) ||
> - format('{0}-{1}', github.workflow, github.ref) }}
> + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
> + && format('{0}-{1}', github.run_id, github.run_attempt)
> + || format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> jobs:
next prev parent reply other threads:[~2023-07-13 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 18:06 Igor Munkin via Tarantool-patches
2023-07-13 8:07 ` Sergey Kaplun via Tarantool-patches
2023-07-13 9:58 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-07-13 17:06 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f2e48d3-3a13-c9f1-46fa-836df321db8b@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox