Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com, kshcherbatov@tarantool.org
Subject: [PATCH v3 1/3] Allow gcov on Mac
Date: Tue, 10 Apr 2018 11:31:44 +0300	[thread overview]
Message-ID: <8e2a74bb3e83159c0e300638a5b7891b05edacc3.1523349020.git.v.shpilevoy@tarantool.org> (raw)
In-Reply-To: <cover.1523349020.git.v.shpilevoy@tarantool.org>
In-Reply-To: <cover.1523349020.git.v.shpilevoy@tarantool.org>

For this it is enough to remove HAVE_GCOV. It checks for gcov
library existance, but the library is unused anyway.

Enabled gcov can be run locally on Mac now.
---
 cmake/profile.cmake | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/cmake/profile.cmake b/cmake/profile.cmake
index 278399155..c82fc0168 100644
--- a/cmake/profile.cmake
+++ b/cmake/profile.cmake
@@ -1,14 +1,7 @@
-check_library_exists (gcov __gcov_flush  ""  HAVE_GCOV)
-
 set(ENABLE_GCOV_DEFAULT OFF)
 option(ENABLE_GCOV "Enable integration with gcov, a code coverage program" ${ENABLE_GCOV_DEFAULT})
 
 if (ENABLE_GCOV)
-    if (NOT HAVE_GCOV)
-    message (FATAL_ERROR
-         "ENABLE_GCOV option requested but gcov library is not found")
-    endif()
-
     add_compile_flags("C;CXX"
         "-fprofile-arcs"
         "-ftest-coverage"
@@ -18,8 +11,6 @@ if (ENABLE_GCOV)
     set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -ftest-coverage")
     set (CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fprofile-arcs")
     set (CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -ftest-coverage")
-
-   # add_library(gcov SHARED IMPORTED)
 endif()
 
 if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
-- 
2.14.3 (Apple Git-98)

  reply	other threads:[~2018-04-10  8:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  8:31 [PATCH v3 0/3] Implement json path access to tuple fields Vladislav Shpilevoy
2018-04-10  8:31 ` Vladislav Shpilevoy [this message]
2018-04-10 10:49   ` [PATCH v3 1/3] Allow gcov on Mac Vladimir Davydov
     [not found] ` <f1302082b4457a03b5d2b3c44526815428de4a0e.1523349020.git.v.shpilevoy@tarantool.org>
2018-04-10 16:36   ` [PATCH v3 2/3] Introduce json_path_parser with Unicode support Vladimir Davydov
2018-04-10 18:42     ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-11  9:20       ` Vladimir Davydov
     [not found] ` <c3b64b7b4e638970864995c895bbd5f736282560.1523349020.git.v.shpilevoy@tarantool.org>
2018-04-13 11:33   ` [PATCH v3 3/3] Lua: implement json path access to tuple fields Vladimir Davydov
2018-04-13 21:51     ` [tarantool-patches] " Vladislav Shpilevoy
2018-04-16  8:35       ` Vladimir Davydov
2018-04-16 10:02         ` Vladislav Shpilevoy
2018-04-22 14:21         ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e2a74bb3e83159c0e300638a5b7891b05edacc3.1523349020.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v3 1/3] Allow gcov on Mac' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox