From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/2] sql: restrict nullable action definitions
Date: Mon, 16 Jul 2018 15:27:58 +0300 [thread overview]
Message-ID: <8e0147b6-9b28-39a1-c7e4-2fd50c05d6b3@tarantool.org> (raw)
In-Reply-To: <7c6f7d73-5b64-0076-38a4-41f8c0a5ebc4@tarantool.org>
> 1. No, is_primkey still is not removed. I see it in struct Column.
I've removed is_primkey and struct Column at all in separate commit that would be sent next this letter.
>> +ccons ::= NULL onconf(R). {
>> + sqlite3AddNotNull(pParse, ON_CONFLICT_ACTION_NONE);
>> + /* Trigger nullability mismatch error if required. */
>> + if (R != ON_CONFLICT_ACTION_DEFAULT)
>
> 2. Why do you need this check?
>>> 4. This test does not work, it fails on syntax, but must fail on action.
>>Ok, I've hacked to make it work this way.
sqlite3AddNotNull would rise and error on rewriting on_conflict;
ON_CONFLICT_ACTION_DEFAULT is returned when no ON CONFLICT action is specified.
> 3. Why sqlite3AddNotNull is called when NULL is allowed?
> Please, rename the function or split it or something.
Renamed to sql_column_nullable_action_add as separate commit.
next prev parent reply other threads:[~2018-07-16 12:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:34 [tarantool-patches] [PATCH v1 0/2] " Kirill Shcherbatov
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 1/2] " Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 20:03 ` Vladislav Shpilevoy
2018-07-16 9:43 ` Kirill Shcherbatov
2018-07-16 10:20 ` Vladislav Shpilevoy
2018-07-16 12:27 ` Kirill Shcherbatov [this message]
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 2/2] sql: fixed possible leak in sqlite3EndTable Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action definitions Vladislav Shpilevoy
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 2/4] sql: refactor sqlite3AddNotNull function Kirill Shcherbatov
2018-07-16 13:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 4/4] sql: get rid of Column structure Kirill Shcherbatov
2018-07-16 13:40 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 16:33 ` Kirill Shcherbatov
2018-07-17 9:32 ` Vladislav Shpilevoy
2018-07-17 14:08 ` Kirill Shcherbatov
2018-07-17 22:01 ` Vladislav Shpilevoy
2018-07-18 7:25 ` Kirill Shcherbatov
2018-07-18 8:04 ` Vladislav Shpilevoy
2018-07-18 16:41 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0147b6-9b28-39a1-c7e4-2fd50c05d6b3@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/2] sql: restrict nullable action definitions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox