Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Roman Khabibov <roman.habibov1@yandex.ru>
Subject: [tarantool-patches] Re: [PATCH] sql: constraints definition among columns in CREATE TABLE()
Date: Mon, 19 Nov 2018 15:41:00 +0300	[thread overview]
Message-ID: <8d84eb1f-95c4-0043-abc7-dc19f663a0df@tarantool.org> (raw)
In-Reply-To: <20181118143151.24016-1-roman.habibov1@yandex.ru>

Hi! Thanks for the patch! Please, fix one minor comment
below.

On 18/11/2018 17:31, Roman Khabibov wrote:
> Allow constraints to appear along with columns definitions. Disallow typing
> a constraint name without specifying the constraint and after.
> 
> Closes #3504
> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3504-constraints-create-table
> Issue: https://github.com/tarantool/tarantool/issues/3504
> diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
> index 8367ec016..65b45de0a 100755
> --- a/test/sql-tap/table.test.lua
> +++ b/test/sql-tap/table.test.lua
> @@ -1,6 +1,6 @@
>   #!/usr/bin/env tarantool
>   test = require("sqltester")
> -test:plan(57)
> +test:plan(68)
>   
>   --!./tcltestrunner.lua
>   -- 2001 September 15
> @@ -1180,4 +1180,143 @@ test:do_test(

Please, add a test that I can not write multiple 'CONSTRAINT <name>'
in a row.

>   
>       -- </table-15.1>
>   })

  reply	other threads:[~2018-11-19 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 14:31 [tarantool-patches] " Roman Khabibov
2018-11-19 12:41 ` Vladislav Shpilevoy [this message]
2018-11-21  5:04   ` [tarantool-patches] " roman.habibov1
2018-11-21 11:01     ` Vladislav Shpilevoy
2018-11-21 19:29     ` n.pettik
2018-11-22  0:23       ` roman.habibov1
2018-11-26 10:33 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d84eb1f-95c4-0043-abc7-dc19f663a0df@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=roman.habibov1@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: constraints definition among columns in CREATE TABLE()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox